MailCommitMapping: do not allow the config to be passed implicitly

Implicit configuration is a recipe for confusion when trying to allow
for overriding said configuration. Let's require the config to be passed
down explicitly.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -59,7 +59,7 @@ export class CIHelper {
         this.workDir = workDir;
         this.notes = new GitNotes(workDir);
         this.gggNotesUpdated = !!skipUpdate;
-        this.mail2commit = new MailCommitMapping(this.notes.workDir);
+        this.mail2commit = new MailCommitMapping(this.config, this.notes.workDir);
         this.mail2CommitMapUpdated = !!skipUpdate;
         this.github = new GitHubGlue(workDir, this.config.repo.owner, this.config.repo.name);
         this.testing = false;

lib/mail-commit-mapping.ts

@@ -1,13 +1,14 @@
 import { git } from "./git.js";
 import { GitNotes } from "./git-notes.js";
-import { IConfig, getConfig } from "./project-config.js";
+import { IConfig } from "./project-config.js";
 
 export class MailCommitMapping {
-    public readonly config: IConfig = getConfig();
+    public readonly config: IConfig;
     public readonly workDir?: string;
     public readonly mail2CommitNotes: GitNotes;
 
-    public constructor(workDir?: string) {
+    public constructor(config: IConfig, workDir?: string) {
+        this.config = config;
         this.workDir = workDir;
         this.mail2CommitNotes = new GitNotes(workDir, "refs/notes/mail-to-commit");
     }