Implement hands on hp-move-tags #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
requested changes
Nov 10, 2025
Comment on lines
+12
to
+19
| """ | ||
| hp-move-tags (T4L2) | ||
| - Fork https://github.com/git-mastery/samplerepo-preferences to user account | ||
| - Clone the fork locally as 'samplerepo-preferences' | ||
| - Create: | ||
| * lightweight tag `v1.0` on HEAD | ||
| * annotated tag `v0.9` on HEAD~2 with message "First beta release" | ||
| """ |
| # Ensure GitHub CLI is authenticated | ||
| gh_user = run_command(["gh", "api", "user", "--jq", ".login"], verbose).strip() | ||
| if not gh_user: | ||
| raise RuntimeError("GitHub CLI not authenticated. Run `gh auth login` and retry.") |
Member
There was a problem hiding this comment.
This is already handled when you set __requires_github__ to True
|
|
||
| # Fresh sandbox, if re-downloading | ||
| if target_dir.exists(): | ||
| import shutil |
Member
There was a problem hiding this comment.
I would avoid local imports, there's no issues with importing it at the start of the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#93
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?