batched-bench : add "separate text gen" mode #17103
Merged
+40
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-tgstollama-batched-benchwould make it decode the sequences separately, one by one:This is useful for benchmarking the performance of the unified KV cache where it's important to detect and skip masked regions in the KQ mask.
Example with the Metal backend:
With the -INF block optimizations in the FA kernels:
Disabling the -INF block optimizations in the FA kernels:
patch
Observe that both
ppandtgperf is worse and it's amplified with more sequences in the cache.