windows/gl: Fix double window class registration #8548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On windows + gl backend:
wgpu_core::instance: Instance::new: failed to create Gl backend: InstanceError { message: "unable to register window class", source: Some(Error { code: HRESULT(0x80070582), message: "Class already exists." }) }This adds an additional check to skip initialization if the window class already exists.
Testing
I ran my wgpu-based VST plugin against this PR and it now works properly.
Without this change, it only managed to initialize once, then subsequent initializations fail to get the adapter.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:[ ]--target wasm32-unknown-unknowncargo xtask testto run tests. <- I don't have a windows machine to run tests on... The aforementioned VST ran on wineCHANGELOG.mdentry.