-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(consumers): ensure that gen_ai spans get the gen_ai.agent.name from the ancestor span
#102955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
constantinius
merged 8 commits into
master
from
constantinius/feat/consumers/ensure-genai-agent-name
Nov 11, 2025
Merged
feat(consumers): ensure that gen_ai spans get the gen_ai.agent.name from the ancestor span
#102955
constantinius
merged 8 commits into
master
from
constantinius/feat/consumers/ensure-genai-agent-name
Nov 11, 2025
+251
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the ancestor span
markstory
reviewed
Nov 7, 2025
…ith predicate whether agent name exists as an attribute
ArthurKnaus
reviewed
Nov 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102955 +/- ##
===========================================
- Coverage 80.63% 80.47% -0.16%
===========================================
Files 9141 9143 +2
Lines 392729 395119 +2390
Branches 24959 24959
===========================================
+ Hits 316669 317978 +1309
- Misses 75653 76734 +1081
Partials 407 407 |
…nvoke_agent ancestors
jjbayer
approved these changes
Nov 10, 2025
ArthurKnaus
reviewed
Nov 10, 2025
…of ancestors, and adjust related tests for clarity and accuracy
obostjancic
approved these changes
Nov 11, 2025
ArthurKnaus
approved these changes
Nov 11, 2025
Member
ArthurKnaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/TET-1293/make-sure-that-agent-name-is-set-on-all-of-its-gen-ai-children
Supersedes: getsentry/sentry-python#5030
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.