Skip to content

test: add tests for either FastMCP implementation #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: add tests for either FastMCP implementation #5075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d306c01
test: add tests for either FastMCP implementation
constantinius Nov 5, 2025
52f09d3
test: add fastmcp to tox population script
constantinius Nov 6, 2025
7e75235
fix: moving fastmcp tests to separate directory
constantinius Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/populate_tox/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@
"*": ["pytest-asyncio"],
},
},
"fastmcp": {
"package": "fastmcp",
"deps": {
"*": ["pytest-asyncio"],
},
},
"openai-base": {
"package": "openai",
"integration_name": "openai",
Expand Down
12 changes: 9 additions & 3 deletions scripts/populate_tox/package_dependencies.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 16 additions & 12 deletions scripts/populate_tox/releases.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions scripts/split_tox_gh_actions/split_tox_gh_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"langgraph",
"litellm",
"mcp",
"fastmcp",
"openai-base",
"openai-notiktoken",
"openai_agents",
Expand Down
3 changes: 3 additions & 0 deletions tests/integrations/fastmcp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import pytest

pytest.importorskip("mcp")
Copy link

@cursor cursor bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Import Check Misroutes Tests to Wrong Package

The __init__.py file for fastmcp tests imports "mcp" instead of "fastmcp". This causes tests to be skipped when the mcp package is not installed, even though the tests are specifically for the fastmcp package. Since these are separate packages (as evidenced by the separate test directories and tox configuration), the importorskip should check for "fastmcp" availability, not "mcp".

Fix in Cursor Fix in Web

Copy link
Contributor Author

@constantinius constantinius Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is on purpose, because FastMCP can either be a part of the MCP SDK or a standalone package but both are dependant on mcp

Loading
Loading