-
-
Notifications
You must be signed in to change notification settings - Fork 19
chore(deps): update Cocoa SDK to v8.57.3 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
287641f to
f4c0761
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 77.97% 74.92% -3.05%
==========================================
Files 44 11 -33
Lines 808 339 -469
Branches 114 52 -62
==========================================
- Hits 630 254 -376
+ Misses 122 57 -65
+ Partials 56 28 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f4c0761 to
9bcd6da
Compare
| spec.osx.deployment_target = '10.13' | ||
| spec.tvos.deployment_target = '11.0' | ||
| spec.watchos.deployment_target = '4.0' | ||
| spec.dependency 'Sentry', '8.57.1' | ||
| spec.dependency 'Sentry', '8.57.3' | ||
|
|
||
| if !Dir.exist?('build/cocoapods/framework/sentry_kotlin_multiplatform.framework') || Dir.empty?('build/cocoapods/framework/sentry_kotlin_multiplatform.framework') | ||
| raise " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Sample app uses outdated Cocoa SDK version 8.57.1 due to un-updated shared.podspec dependency.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The sample application kmp-app-cocoapods will use an outdated Cocoa SDK version 8.57.1 instead of the intended 8.57.3. This is because sentry-samples/kmp-app-cocoapods/shared/shared.podspec was not updated to reflect the new dependency version, while the main library's sentry_kotlin_multiplatform.podspec was. This inconsistency means the sample app will miss critical bug fixes, such as the one resolving an SDK crash caused by UIPrintPanelViewController incorrectly casting to UISplitViewController (#6771).
💡 Suggested Fix
Update the Sentry dependency version in sentry-samples/kmp-app-cocoapods/shared/shared.podspec from 8.57.1 to 8.57.3 to match the main library.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: sentry-kotlin-multiplatform/sentry_kotlin_multiplatform.podspec#L12-L18
Potential issue: The sample application `kmp-app-cocoapods` will use an outdated Cocoa
SDK version `8.57.1` instead of the intended `8.57.3`. This is because
`sentry-samples/kmp-app-cocoapods/shared/shared.podspec` was not updated to reflect the
new dependency version, while the main library's `sentry_kotlin_multiplatform.podspec`
was. This inconsistency means the sample app will miss critical bug fixes, such as the
one resolving an SDK crash caused by `UIPrintPanelViewController` incorrectly casting to
`UISplitViewController`
([#6771](https://github-redirect.dependabot.com/getsentry/sentry-cocoa/issues/6771)).
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3543901
Bumps scripts/update-cocoa.sh from 8.57.1 to 8.57.3.
Auto-generated by a dependency updater.
Changelog
8.57.3
Fixes
SentryCppHelperto Sentry (#6754) (#6761)8.57.2
Fixes
Views now need to be fully opaque (view and layer backgrounds with alpha == 1) and report opaque to qualify for clip‑out.
This avoids leaks at the cost of fewer clip‑out optimizations.