fix(nextjs): Drop meta trace tags if rendered page is ISR #18192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/js-1152-nextjs-incremental-static-rendering-causes-cached-trace-id
branch
from
73ec1ba to
54be3bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ISR pages will have a
sentry-traceandbaggagemeta tags rendered on them following the initial render or after the first invalidation causing a cached trace id to be present until the next invalidation.This happens in Next.js 15/16 and both on Turbopack and Webpack.
Implementation
I Found no way to conditionally set/unset/change the values set by the
clientTraceMetadataoption, I found nothing useful on unit async storages, nor re-setting the propagation context works. TheclientTraceMetadatagets called way earlier at theapp-render.tsxlevel, so we cannot change it per page as it has already run.so this is a bit of a workaround, I decided to do it on the client side by:
Sentry.initcall we remove the tags before the browser integration has had a chance to grab the meta tags.Not the cleanest way, but I verified the issue by writing tests for it and making sure that the solution does resolve them.