Skip to content

Conversation

@chargome
Copy link
Member

With this PR users can set their min replay duration to max 50s, previously this was capped at 15s.

We cannot bump this value further as this would lead to dropping buffered replays (we keep max. 60s in-memory at this point)

closes #18109

@chargome chargome self-assigned this Nov 12, 2025
@chargome chargome requested a review from a team as a code owner November 12, 2025 16:29
chargome and others added 2 commits November 12, 2025 17:33
…DurationLimit/init.js

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
…DurationLimit/test.ts

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@chargome
Copy link
Member Author

@billyvg just wondering, would we not also drop buffered replays here since they can be anywhere from 0-60s?

@billyvg
Copy link
Member

billyvg commented Nov 13, 2025

@billyvg just wondering, would we not also drop buffered replays here since they can be anywhere from 0-60s?

Yeah i think we just have to strongly warn users about this if we are going to add it.

Though looking at [the code]... it seems like we only consider the session start to current flush time as the "duration" - I can't recall if, while in buffer mode, we mutate the session.start time at all we do


/*
The max. allowed value that the minReplayDuration can be set to.
This needs to be below 60s, so we don't unintentionally drop buffered replays that are longer than 60s.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the comment in the replay options type so that it's visible to users. We should also be clear that this can drop onError-sampled replays

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 10,765 - 8,786 +23%
GET With Sentry 1,586 15% 1,357 +17%
GET With Sentry (error only) 7,312 68% 6,118 +20%
POST Baseline 1,137 - 1,190 -4%
POST With Sentry 521 46% 524 -1%
POST With Sentry (error only) 997 88% 1,049 -5%
MYSQL Baseline 3,838 - 3,304 +16%
MYSQL With Sentry 464 12% 450 +3%
MYSQL With Sentry (error only) 3,168 83% 2,716 +17%

View base workflow run

@chargome chargome merged commit 7efb1d2 into develop Nov 13, 2025
193 checks passed
@chargome chargome deleted the cg-replay-bump-min-duration branch November 13, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow minReplayDuration to be longer than just 15 seconds

4 participants