Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Oct 27, 2025

Opt-in, Android-only solution for:

According to our newly introduced Android integration tests, getsentry/sentry-native#1392 works on android-arm64 and android-x64 in both Release and Debug configurations, but we'd like to validate the fix further in real-world conditions. To that end, we're making it opt-in initially so customers can try it on more devices, platforms, and configurations before considering it as the new default.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- native signal handler strategy on Android ([#4676](https://github.com/getsentry/sentry-dotnet/pull/4676))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 4486918

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.87%. Comparing base (356f8e9) to head (4486918).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4676      +/-   ##
==========================================
+ Coverage   73.85%   73.87%   +0.01%     
==========================================
  Files         485      485              
  Lines       17689    17689              
  Branches     3496     3496              
==========================================
+ Hits        13064    13067       +3     
+ Misses       3765     3762       -3     
  Partials      860      860              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Nov 4, 2025

@jamescrosswell This is marked as a draft because it's still waiting for dependencies, but we could already kick off the review process if you have time. :)

Do you have a preferred approach for exposing this as an opt-in API? The current proposal mirrors the sentry-native enum.

#if ANDROID
    options.Native.SignalHandlerStrategy = Sentry.Android.SignalHandlerStrategy.ChainAtStart;
#endif

With only two values, a simple boolean flag could also work for the time being, but I'm unsure if potential Android Tombstone support could change things in the future.

Base automatically changed from version6 to main November 14, 2025 02:30
@jpnurmi jpnurmi force-pushed the feat/android-signal-handler-strategy branch from af57caa to 4486918 Compare November 20, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants