enh: refactor `init` to use JNI/FFI #3324

buenaflor · 2025-11-06T16:17:26Z

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-11-06T16:17:51Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- refactor `init` to use JNI/FFI ([#3324](https://github.com/getsentry/sentry-dart/pull/3324))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against fde01d6

github-actions · 2025-11-06T16:18:06Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

github-actions · 2025-11-06T16:31:15Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1259.23 ms	1254.90 ms	-4.33 ms
Size	5.53 MiB	6.02 MiB	502.32 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6f47800`	1247.52 ms	1259.37 ms	11.85 ms
`6bcdc99`	1257.16 ms	1264.96 ms	7.79 ms
`765aa8b`	1259.09 ms	1269.90 ms	10.82 ms
`73a3c38`	1263.37 ms	1277.90 ms	14.53 ms
`0fb45d0`	1273.24 ms	1286.44 ms	13.19 ms
`aeb02f2`	1244.29 ms	1256.55 ms	12.26 ms
`f761369`	1261.69 ms	1277.82 ms	16.12 ms
`0fb3800`	1256.60 ms	1266.28 ms	9.68 ms
`e04b24b`	1230.22 ms	1233.90 ms	3.67 ms
`1f639ee`	1252.43 ms	1257.82 ms	5.38 ms

App size

Revision	Plain	With Sentry	Diff
`6f47800`	7.86 MiB	9.44 MiB	1.58 MiB
`6bcdc99`	5.53 MiB	6.00 MiB	479.95 KiB
`765aa8b`	7.86 MiB	9.44 MiB	1.58 MiB
`73a3c38`	7.86 MiB	9.44 MiB	1.58 MiB
`0fb45d0`	7.86 MiB	9.44 MiB	1.58 MiB
`aeb02f2`	7.86 MiB	9.44 MiB	1.58 MiB
`f761369`	7.86 MiB	9.44 MiB	1.58 MiB
`0fb3800`	7.86 MiB	9.44 MiB	1.58 MiB
`e04b24b`	5.53 MiB	6.00 MiB	480.00 KiB
`1f639ee`	5.53 MiB	6.00 MiB	479.95 KiB

buenaflor · 2025-11-11T13:30:49Z

packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

-      if (!sentryFlutter.autoPerformanceTracingEnabled) {
-        return null
-      }
-


removing it here, we have this check in the Dart side

packages/flutter/example/lib/main.dart

buenaflor · 2025-11-11T13:36:31Z

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa.dart

 final ObjCObjectBase Function(Object) _defaultObjcConverter = (obj) {
  return switch (obj) {
-    bool b => b ? 1.toNSNumber() : 0.toNSNumber(),
+    bool b => NSNumberCreation.numberWithBool(b),


previous convert was wrong, it should've been using NSNumberCreation

denrase · 2025-11-11T15:47:45Z

packages/flutter/ios/sentry_flutter/Sources/sentry_flutter/SentryFlutterPlugin.swift

+    #endif
+  }
+
+  @objc(setBeforeSend:packages:integrations:)


Don't think we need different naming for objc, as this will never be called from Swift directly.

This is so it's more explicit how the name is generated for objc

without it it's setBeforeSendWithOptions(...) by default

this took a lot of time away from me because I couldn't figure out why the app was crashing and it turns out I should've used setBeforeSendWithOptions in SentryFlutterPlugin.h when creating the bindings instead of only setBeforeSend.

In the end I decided to add this so it's explicit how it's converted

I don't mind reverting it, though I think it would be helpful for the future to be more specific

packages/flutter/ios/sentry_flutter/Sources/sentry_flutter/SentryFlutterPlugin.swift

packages/flutter/ios/sentry_flutter/Sources/sentry_flutter_objc/SentryFlutterPlugin.h

denrase · 2025-11-11T16:08:00Z

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa.dart

-                  : e as Object
-        ],
+      List<dynamic> l => _deepConvertListNonNull(l),
      _ => value as Object,


Also here, toObjCObject not needed?

same comment as above, this function doesn't do any objc conversions

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa_init.dart

denrase · 2025-11-11T16:17:13Z

packages/flutter/ffi-cocoa.yaml

-  - '-I./temp/Sentry.framework/Headers/'
-  - '-I./temp/Sentry.framework/PrivateHeaders/'
-  - '-I./ios/sentry_flutter/Sources/sentry_flutter_objc/'
+  - -DFFIGEN=1


What does this compiler option do?

See ffigen_objc_imports.h

#ifdef FFIGEN // Only included while running ffigen (provide paths in compiler-opts). #import "PrivateSentrySDKOnly.h" #import "Sentry-Swift.h" #import "SentryOptions.h" #import "SentryScope.h" #endif

if we dont have this it will complain when compiling the app. We only need these headers when we use ffigen

denrase · 2025-11-11T16:18:15Z

packages/flutter/lib/src/replay/replay_quality.dart

-  high(resolutionScalingFactor: 1.0),
-  medium(resolutionScalingFactor: 1.0),
-  low(resolutionScalingFactor: 0.8);
+  high(resolutionScalingFactor: 1.0, level: 2),


Why the addition of level?

so we can map it directly to cocoa quality:

quality: options.replay.quality.level,

alternatively we could remove it and just do it on the call site

packages/flutter/lib/src/sentry_privacy_options.dart

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa_init.dart

buenaflor · 2025-11-11T17:20:00Z

I'm currently working on optimizing the JNI bindings so it only creates bindings for fields and methods we specify

buenaflor added 4 commits November 6, 2025 14:36

Android side

e53fa94

Update

2748859

Update

6033ea8

Update

b864cf0

buenaflor added 12 commits November 7, 2025 21:03

Simple ios ffi gen

cb9f451

Fix compilation

0f1a611

Update

23d49da

Update

3e15e01

Remove method channel

36491eb

Remove unnecessary code

256ad72

Update

561d56e

Update

89079ed

Update

1dab36d

Update

d7fe123

newlines

747c4c3

newlines

b8d8378

buenaflor commented Nov 11, 2025

View reviewed changes

buenaflor added 4 commits November 11, 2025 14:31

Update

9d18550

Update

444175e

Update

7264607

Update

63bb590

buenaflor commented Nov 11, 2025

View reviewed changes

packages/flutter/example/lib/main.dart Show resolved Hide resolved

Update

a968e32

buenaflor commented Nov 11, 2025

View reviewed changes

buenaflor changed the title ~~(DRAFT) enh: refactor init to use JNI/FFI~~ enh: refactor init to use JNI/FFI Nov 11, 2025

buenaflor and others added 2 commits November 11, 2025 14:38

Merge branch 'main' into enh/ffi-jni-init

1d807c3

Remove macos symlink to SentryFlutter.swift

48fdf3a

buenaflor added 3 commits November 11, 2025 16:03

Ktlint

e4e447f

Ktlint

7bcea70

Ktlint

3ab4b17

denrase requested changes Nov 11, 2025

View reviewed changes

buenaflor commented Nov 11, 2025

View reviewed changes

packages/flutter/lib/src/sentry_privacy_options.dart Outdated Show resolved Hide resolved

buenaflor commented Nov 11, 2025

View reviewed changes

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa_init.dart Outdated Show resolved Hide resolved

buenaflor added 4 commits November 11, 2025 17:32

Reuse setSdkMetaData

2579aaf

Update

af59e30

Update

eb398be

remove duplicate typedef capture callback

64f2078

buenaflor added 19 commits November 11, 2025 18:22

Generate JNI bindings tool

8892a46

Update

b4ca367

Update

9eae5fa

Optimize JNI bindings size

ade6888

Update

b07b9e4

Update jni binding creation

85cb83f

Swiftlint fix

b2a2c33

Format

61b799a

Fix macos integration tests

490f204

Update

c2fbcd9

Update

16c8522

Update

0fc6690

Fix android test

60f5d20

Update

eb6c5c4

Update

9156fbb

Update

0fb645a

Try fix ios integration test

552f14b

Update

b5a2b91

Update

fde01d6

Uh oh!

enh: refactor init to use JNI/FFI #3324

Are you sure you want to change the base?

enh: refactor init to use JNI/FFI #3324

Uh oh!

Conversation

buenaflor commented Nov 6, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instructions and example for changelog

Uh oh!

github-actions bot commented Nov 6, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

buenaflor Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

buenaflor Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

denrase Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

buenaflor Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

denrase Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

buenaflor Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

denrase Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

buenaflor Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

denrase Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

buenaflor Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

buenaflor commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

enh: refactor `init` to use JNI/FFI #3324

enh: refactor `init` to use JNI/FFI #3324

github-actions bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading

buenaflor Nov 11, 2025 •

edited

Loading

buenaflor Nov 11, 2025 •

edited

Loading

buenaflor Nov 11, 2025 •

edited

Loading

buenaflor Nov 11, 2025 •

edited

Loading