Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
cli:
if: github.repository == 'getsentry/sentry-android-gradle-plugin'
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect uses syntax for getsentry/github-workflows v3, referencing a reusable workflow instead of a composite action.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The workflow attempts to use getsentry/github-workflows/.github/workflows/updater.yml@v3, which is the syntax for a reusable workflow. However, v3 of getsentry/github-workflows provides updater as a composite action, requiring the syntax getsentry/github-workflows/updater@v3. This syntax mismatch will prevent GitHub Actions from locating and executing the workflow at lines 16 and 27, causing the jobs to fail.

💡 Suggested Fix

Change uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 to uses: getsentry/github-workflows/updater@v3 at lines 16 and 27.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/update-deps.yml#L16

Potential issue: The workflow attempts to use
`getsentry/github-workflows/.github/workflows/updater.yml@v3`, which is the syntax for a
reusable workflow. However, `v3` of `getsentry/github-workflows` provides `updater` as a
composite action, requiring the syntax `getsentry/github-workflows/updater@v3`. This
syntax mismatch will prevent GitHub Actions from locating and executing the workflow at
lines 16 and 27, causing the jobs to fail.

Did we get this right? 👍 / 👎 to inform future reviews.

with:
path: plugin-build/sentry-cli.properties
name: CLI
Expand All @@ -24,7 +24,7 @@ jobs:

android:
if: github.repository == 'getsentry/sentry-android-gradle-plugin'
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-android.sh
name: Android SDK
Expand Down
Loading