-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: pre-release v0.0.28 #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
459218a
fix: remove integration router exports
amhsirak 2e6e89e
fix: remove integration router exports
amhsirak eb512d8
fix: required page instance scrape action
RohitR311 d538419
fix: rm duplicate io export
RohitR311 2bbf5d6
chore: mv ci to install
RohitR311 560b2e3
chore: rm chromium backend image
RohitR311 c963feb
chore: core v0.0.28
amhsirak 53a3490
chore: v0.0.28
amhsirak f027283
chore: use maxun-core v0.0.28
amhsirak 2f0516f
chore: mv pw to pw-core
RohitR311 b2fcf02
fix: pagination ui
RohitR311 bbfa78e
fix: wss launch config
RohitR311 ace57d8
fix: wss endpoint
RohitR311 068a28a
fix: ui remove pagination
RohitR311 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 159
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 7400
🏁 Script executed:
# Check the Dockerfile.backend for any system dependency installation cat Dockerfile.backendRepository: getmaxun/maxun
Length of output: 630
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 199
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 1873
🏁 Script executed:
# Check the full browserConnection.ts file to understand the context wc -l server/src/browser-management/browserConnection.tsRepository: getmaxun/maxun
Length of output: 112
🏁 Script executed:
# Look at the full file if it's not too large cat -n server/src/browser-management/browserConnection.tsRepository: getmaxun/maxun
Length of output: 6979
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 3388
🏁 Script executed:
Repository: getmaxun/maxun
Length of output: 3148
Remove local Chromium fallback or add Chromium binaries to Dockerfile.backend.
Switching from
mcr.microsoft.com/playwright:v1.46.0-nobletonode:20-slimcreates a critical runtime failure. The code inserver/src/browser-management/browserConnection.tsimplements a fallback mechanism: it attempts to connect to a remote browser service first, but if that fails, it callslaunchLocalBrowser()(line 128), which requires Chromium binaries and system libraries not present in the minimal base image.When the remote browser service is unavailable,
chromium.launch()will fail because:npx playwright install chromium)Either install Chromium in the Dockerfile with
RUN npx playwright@1.57.0 install chromium(and system packages), or remove the fallback and enforce remote browser service as mandatory.🤖 Prompt for AI Agents