node-executor: Don’t analyze contents of _deps (#40415)

When node-executor analyzes the contents of a Node module, it shouldn’t take into account chunk files (files in the `_deps` folder). These files are named with temporary names, so it wouldn’t make sense for users to want to expose a function from there.

GitOrigin-RevId: 234abcb963f260732f3a4d2a0f7cc778dc544a14

Author: Nicolapps

npm-packages/node-executor/src/source_package.ts

@@ -304,6 +304,10 @@ async function processExternalPackageStream(
 
 type LocalSourcePackage = {
   dir: string;
+  /**
+   * The modules included in the package and that could contain Convex functions.
+   * This doesn’t include bundler chunks (files in /_deps/).
+   */
   modules: Set<CanonicalizedModulePath>;
   dynamicallyDownloaded: boolean;
 };
@@ -440,7 +444,10 @@ function modulesFromMetadataJson(
 ): Set<CanonicalizedModulePath> {
   const modules: Set<string> = new Set();
   for (const path of metadataJson.modulePaths) {
-    if (path.endsWith(".js")) {
+    if (path.startsWith("_deps/")) {
+      // Ignore bundler chunks since they don’t contain Convex function definitions.
+      continue;
+    } else if (path.endsWith(".js")) {
       // Only load node files.
       const environment = metadataJson.moduleEnvironments.get(path);
       if (!environment) {

npm-packages/node-executor/test/integration-test.ts

@@ -485,13 +485,19 @@ async function test_download() {
 
   const local = await maybeDownloadAndLinkPackages(sourcePackage);
   const sourceDir = path.join(os.tmpdir(), `source/test_modules_key`);
+
   assert.equal(local.dir, sourceDir);
   assert.equal(local.modules.has("a.js"), true);
   assert.equal(local.modules.has("someFolder/someFile.js"), true);
+
   // Non-node modules
   assert.equal(local.modules.has("third_party.js"), false);
   assert.equal(local.modules.has("d.js"), false);
 
+  // We don’t include _deps in `.modules` since they can’t contain Convex functions
+  assert.equal(local.modules.has("_deps/node/sample_node.js"), false);
+  assert.equal(local.modules.has("_deps/sample_isolate.js"), false);
+
   // Assert external deps package exists after download
   const externalDepsDir = path.join(
     os.tmpdir(),

npm-packages/node-executor/test/metadata.json

@@ -1,5 +1,7 @@
 {
   "modulePaths": [
+    "_deps/node/sample_node.js",
+    "_deps/sample_isolate.js",
     "a.js",
     "b.js",
     "c.js",
@@ -18,6 +20,8 @@
     "transitive.js"
   ],
   "moduleEnvironments": [
+    ["_deps/node/sample_node.js", "node"],
+    ["_deps/sample_isolate.js", "isolate"],
     ["a.js", "node"],
     ["b.js", "isolate"],
     ["c.js", "isolate"],