fix(zero-style): correct timestep handling in episode continuation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix off-by-one error in episode data API (timestep N should read line N+1) - Fix initial timestep in zero-style simulator (start from timestep+1 to avoid collision) - Remove TODO comment about incorrect inference_human timestep Fixes issue where human inference timestep was colliding with the last timestep in the loaded attribution log, causing incorrect training signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed episode data API off-by-one error (
route.ts)Fixed initial timestep calculation (
StateServiceHumanSimulator.ts)setInitialTimestep()to start fromtimestep + 1Removed resolved TODO comment (
ZeroStyleApp.tsx)Impact
Testing
Files Changed
web-ui/src/app/api/episode-data/route.ts(+9/-4)web-ui/src/simulation/simulators/StateServiceHumanSimulator.ts(+4/-2)web-ui/src/ZeroStyleApp.tsx(+1/-2)