-
Notifications
You must be signed in to change notification settings - Fork 56
resources: GPUFS: ROCm 7.0 and MI350 support #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Conversation
powerjg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @Harshil2107 can you generate a new version?
@abmerop Is this intended to replace the current disk image as a new version or to live alongside? If the latter, then we should duplicate the files.
|
I will upload the new version. I noticed the disk image has the same name as the already existing gpu image. Are the kernel and the disk extracted from this image supposed to replace the already existing disk and kernel or should they be added an new resources? |
|
I am not aware of any existing resources. |
mattsinc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
We have the following disk and kernel already upload to resources that were made from the source that was updated in this PR.
would it be ok to replace these resouces with the updated ones created from this PR? or do we want to create a new copy? |
Ah ok. I think I see you point then. How about I rename the output that would be created in this PR to include the ROCm version? I am not sure what version is on those disks without downloading it. |
|
Changed script to name the output files with the major/minor version of ROCm. In this case the disk would be The disk/kernel uploaded is ROCm 6.1. If you wanted to retroactively rename it (maybe via symlink, http/301, etc. to avoid dead links). |
Intended to be merged with v25.1 release