Skip to content

Conversation

@abmerop
Copy link
Member

@abmerop abmerop commented Nov 13, 2025

Intended to be merged with v25.1 release

Copy link
Contributor

@powerjg powerjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @Harshil2107 can you generate a new version?

@abmerop Is this intended to replace the current disk image as a new version or to live alongside? If the latter, then we should duplicate the files.

@Harshil2107
Copy link
Contributor

I will upload the new version. I noticed the disk image has the same name as the already existing gpu image. Are the kernel and the disk extracted from this image supposed to replace the already existing disk and kernel or should they be added an new resources?

@abmerop
Copy link
Member Author

abmerop commented Nov 20, 2025

I am not aware of any existing resources.

@mattsinc mattsinc self-requested a review November 23, 2025 23:37
@mattsinc mattsinc added the enhancement New feature or request label Nov 23, 2025
mattsinc
mattsinc previously approved these changes Nov 23, 2025
Copy link
Contributor

@mattsinc mattsinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@Harshil2107
Copy link
Contributor

I am not aware of any existing resources.

We have the following disk and kernel already upload to resources that were made from the source that was updated in this PR.

would it be ok to replace these resouces with the updated ones created from this PR? or do we want to create a new copy?

@abmerop
Copy link
Member Author

abmerop commented Nov 24, 2025

I am not aware of any existing resources.

We have the following disk and kernel already upload to resources that were made from the source that was updated in this PR.

would it be ok to replace these resouces with the updated ones created from this PR? or do we want to create a new copy?

Ah ok. I think I see you point then. How about I rename the output that would be created in this PR to include the ROCm version? I am not sure what version is on those disks without downloading it.

@abmerop
Copy link
Member Author

abmerop commented Nov 26, 2025

Changed script to name the output files with the major/minor version of ROCm. In this case the disk would be x86-ubuntu-rocm70 and vmlinux-rocm70.

The disk/kernel uploaded is ROCm 6.1. If you wanted to retroactively rename it (maybe via symlink, http/301, etc. to avoid dead links).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants