-
-
Notifications
You must be signed in to change notification settings - Fork 123
Add MASK_EN note #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add MASK_EN note #629
Conversation
Close gbdev#625
|
Wait, really? I thought only another |
|
Maybe it needs clarification. If the screen was frozen by clearing LCDC, it will be unfrozen when its bit 7 is set. |
|
Ah, I see: it's another freezing mechanism, separate from |
|
Yes. Enlightened by beware. |
ISSOtm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'd like to suggest the following wording:
| SGB freezes/unfreezes the Game Boy screen automatically whenever the LCD is | ||
| turned off/on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| SGB freezes/unfreezes the Game Boy screen automatically whenever the LCD is | |
| turned off/on. | |
| The screen retains its last frame when the "LCD" is [turned off](<#LCDC.7 — LCD enable>), though it gets blanked out after a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "stops updating" might confuse people, although it's technically correct.
I'm not sure what "gets blanked out after a while" means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, leaving the screen turned off for a significant period of time causes the SGB firmware to blank out the framebuffer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a lot of detail that could be discovered through hardware research. Personally, I'd prefer to hold off on edits that go from saying something that's unconfirmed and maybe half correct to something else that's that's unconfirmed and maybe half correct. Especially when it comes to the SGB which is a device that both most people don't have access to, and isn't emulated 100% accurately, even in low level emulators that emulate the SNES portion of the equation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to call Cubby 🐻️ again for a test of how long it takes SGB to discard the last frame after LCD off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, then following Nitro's logic, we should not include the original claim at all either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition of that claim is tracked by #625, btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where "it gets blanked out after a while" came from. Cubby didn't know either 🐻️
I wrote a test ROM that displays an image, turns off LCD while the A Button is held, and turns LCD back on once the A Button is released. DMG and GBC hid the image while A is held. NTSC SGB1 retained the image for my entire patience (about 20 seconds) and showed a little blip at the bottom of the play area indicating that the ICD2 was once again receiving signal from LCD out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we safely remove the "gets blanked out after a while" bit?
Close #625