-
Notifications
You must be signed in to change notification settings - Fork 75
Create an API layer for external process #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MrLuje
wants to merge
22
commits into
fsprojects:master
Choose a base branch
from
MrLuje:api_layer_version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b98d537
add FSharpLint.Client project
MrLuje f1bf916
add client tests
MrLuje 5bdd1ec
cleanup TestDaemonVersion
MrLuje 9b62dd2
update README.md
MrLuje f9e9551
remove reference from FSharpLint.Client to FSharpLint.Core (which inc…
MrLuje f63cc3d
test: ensure FCS is not referenced by FSharpLint.Client
MrLuje 0f1c67f
add FSHARPLINT_SEARCH_PATH_OVERRIDE env var to override search location
MrLuje 670316f
PR feedback: -g -> --global
MrLuje a1d7585
PR feedback: simplify DOTNET_CLI_UI_LANGUAGE env var usage
MrLuje 153ff7e
PR feedback: clearer FSharpLintResponseCode
MrLuje 8dec302
PR feedback: Folder check
MrLuje fdf1855
PR feedback: UnexpectedException
MrLuje 218c1f0
PR feedback: comment about Path.GetFullPath
MrLuje b934f5f
PR feedback: Path.GetFullPath readability
MrLuje 3956ecc
PR feedback: reuse DirectoryInfo instance
MrLuje ff5189a
Сlient: introduce File type
webwarrior-ws 07c5e11
FL0084
MrLuje 9d5283c
FL0043
MrLuje 2da5c06
FL0055
MrLuje 798b699
fix more rules
MrLuje f282341
PR feedback: Folder FromFile/FromFolder
MrLuje b9be6d0
WIP: remove disable-next-line RedundantNewKeyword
Mersho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| module FSharpLint.Client.Contracts | ||
|
|
||
| open System | ||
| open System.Threading | ||
| open System.Threading.Tasks | ||
|
|
||
| [<RequireQualifiedAccess>] | ||
| module Methods = | ||
| [<Literal>] | ||
| let Version = "fsharplint/version" | ||
|
|
||
| type VersionRequest = | ||
| { | ||
| FilePath: string | ||
| } | ||
|
|
||
| type FSharpLintResult = | ||
| | Content of string | ||
|
|
||
| type FSharpLintResponse = { | ||
| Code: int | ||
| FilePath: string | ||
| Result : FSharpLintResult | ||
| } | ||
|
|
||
| type IFSharpLintService = | ||
| interface | ||
| inherit IDisposable | ||
|
|
||
| abstract member VersionAsync: VersionRequest * ?cancellationToken: CancellationToken -> Task<FSharpLintResponse> | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| module FSharpLint.Client.Contracts | ||
|
|
||
| open System.Threading | ||
| open System.Threading.Tasks | ||
|
|
||
| module Methods = | ||
|
|
||
| [<Literal>] | ||
| val Version: string = "fsharplint/version" | ||
|
|
||
| type VersionRequest = | ||
| { | ||
| FilePath: string | ||
| } | ||
|
|
||
| type FSharpLintResult = | ||
| | Content of string | ||
|
|
||
| type FSharpLintResponse = { | ||
| Code: int | ||
| FilePath: string | ||
| Result : FSharpLintResult | ||
| } | ||
|
|
||
| type IFSharpLintService = | ||
| inherit System.IDisposable | ||
|
|
||
| abstract VersionAsync: VersionRequest * ?cancellationToken: CancellationToken -> Task<FSharpLintResponse> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <IsPackable>true</IsPackable> | ||
| <RootNamespace>FSharpLint.Client</RootNamespace> | ||
| <EnableDefaultItems>false</EnableDefaultItems> | ||
| <Title>FSharpLint.Client</Title> | ||
| <Description>Companion library to format using FSharpLint tool.</Description> | ||
| <PackageTags>F#;fsharp;lint;FSharpLint;fslint;api</PackageTags> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="Contracts.fsi" /> | ||
| <Compile Include="Contracts.fs" /> | ||
| <Compile Include="LSPFSharpLintServiceTypes.fsi" /> | ||
| <Compile Include="LSPFSharpLintServiceTypes.fs" /> | ||
| <Compile Include="FSharpLintToolLocator.fsi" /> | ||
| <Compile Include="FSharpLintToolLocator.fs" /> | ||
| <Compile Include="LSPFSharpLintService.fsi" /> | ||
| <Compile Include="LSPFSharpLintService.fs" /> | ||
| </ItemGroup> | ||
| <Import Project="..\..\.paket\Paket.Restore.targets" /> | ||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.