Skip to content

Conversation

@su8898
Copy link
Contributor

@su8898 su8898 commented Dec 20, 2021

Fixes #526

@duckmatt
Copy link
Collaborator

I think it may be possible to express this as one of the hints, although I'm not averse to an additional rule either. Trade off is the rule is easier to ignore one rule specifically, but adding an additional hint should have better performance over an additional rule

(Also apologies, just merged in another PR so needs conflicts resolved)

@knocte
Copy link
Collaborator

knocte commented May 6, 2022

Disadvantages of converting this into a hint:

  1. Can't be disabled by default (and I've already known 2 people which don't like this rule).
  2. There's already a hint that recommends you to use [x] instead of x::[], so fixing this hint might lead to yet another hint, unless we change that hint to recommend a Singleton func, but should we? (See 1. :) )

@knocte
Copy link
Collaborator

knocte commented May 6, 2022

...just merged in another PR so needs conflicts resolved)

No worries, I'll rebase myself soon.

@knocte
Copy link
Collaborator

knocte commented Nov 21, 2022

Superseded by #587

@knocte knocte closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should favour use of singleton function

3 participants