Cleanup: remove dead code, improve test coverage #228
Merged
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelbraaksma
added
refactoring
Closed
abelbraaksma
force-pushed
the
remove-dead-code
branch
from
2cdedb5 to
7111a31
Compare
bartelink
approved these changes
Dec 25, 2023
bartelink
reviewed
Dec 28, 2023
Co-Authored-By: Ruben Bartelink <ruben@bartelink.com>
abelbraaksma
force-pushed
the
remove-dead-code
branch
from
a0a81e9 to
da701b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. @bartelink found a bunch of unused parameters in #225. This PR aims to address those.