Skip to content

Conversation

@rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Nov 11, 2025

Refactors the DPP script primarily to improve code structure and readability.

  • General organization and consolidation
  • Use of helper functions for logic like getting valid_prompts and separate types of tests (metric, token, etc.)
  • Separates AIU and CPU validation generation

Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq rafvasq force-pushed the refactor-cpu-validation branch from 45f661c to 8e99ab7 Compare November 11, 2025 19:45
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq rafvasq force-pushed the refactor-cpu-validation branch from 4642142 to 340c383 Compare November 14, 2025 19:16
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq rafvasq changed the title WIP: Refactor to save cpu outputs prior to model compilation WIP: Refactor DPP script Nov 17, 2025
@rafvasq rafvasq marked this pull request as ready for review November 17, 2025 16:47
@rafvasq rafvasq changed the title WIP: Refactor DPP script Refactor DPP script Nov 17, 2025
Copy link
Contributor

@prashantgupta24 prashantgupta24 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth putting a main function too so that we can do something like this?

if __name__ == "__main__":
    main()

That might simplify this too: https://github.com/foundation-model-stack/aiu-fms-testing-utils/blob/main/pyproject.toml#L49

Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@prashantgupta24
Copy link
Contributor

Also worth checking if the above changes affect the project.scripts: https://github.com/foundation-model-stack/aiu-fms-testing-utils/blob/main/pyproject.toml#L49

Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq rafvasq mentioned this pull request Nov 18, 2025
@rafvasq rafvasq force-pushed the refactor-cpu-validation branch from eed279a to 0146eb7 Compare November 18, 2025 20:19
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq rafvasq force-pushed the refactor-cpu-validation branch from 3abee83 to 3debfea Compare November 18, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants