-
Notifications
You must be signed in to change notification settings - Fork 0
planning: roadmap DAG styling + SVG; issue sweep; ISSUES.md #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flyingrobots
wants to merge
33
commits into
main
Choose a base branch
from
chore/issues-roadmap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
34f8ef2
Roadmap DAG source lands in docs/ROADMAP-DAG.mmd
flyingrobots 156fa6d
Docs: render ROADMAP DAG to SVG
flyingrobots 3df7044
Docs: group Roadmap DAG by milestone (subgraphs)
flyingrobots 3a9aa5a
Docs: colorize DAG by milestone; mark roots; hard vs soft edges
flyingrobots 87fb754
Tools: add roadmap sweep to normalize milestones and embed dependencies
flyingrobots badb5cf
Planning: enrich ISSUES.md (Priority/Estimate) and add Appendix A chains
flyingrobots efa2ad1
Roadmap: use REST to set 'blocked by' issue dependencies in sweep
flyingrobots 781443c
Org: CODEOWNERS + PR template; hooks/targets; risk pass; issue body b…
flyingrobots d291d6e
Submodule: add external/ledger-kernel (spec + schemas)
flyingrobots 24c693d
Docs: add DRIFT_REPORT.md comparing roadmap to Ledger‑Kernel spec
flyingrobots 49449b0
Compliance: add scaffolding (headers, stubs, meson) and artifact work…
flyingrobots 01522cb
Sweep: treat Mermaid '-->' as hard dependency edges (not just '==>')
flyingrobots 3584085
Submodule: remove floating branch; pin external/ledger-kernel to curr…
flyingrobots c367d3b
Docs: replace DRIFT_REPORT date placeholder with actual UTC timestamp
flyingrobots 5610f1a
Feedback: YAML tidy, submodule pin, drift timestamp, robust hooks/Mak…
flyingrobots 2e03635
Merge: resolve conflicts with origin/main (prefer enriched branch con…
flyingrobots dd660c8
Link the compliance smoke to its helper library; keep website artifac…
flyingrobots 4a250e9
Roadmap/docs/build hygiene and compliance hardening\n\n- Docs: remove…
flyingrobots 12561d6
DAG validator: detect hard-edge cycles and report a minimal cycle pat…
flyingrobots a45644e
Add FEEDBACK.md to git ignore
flyingrobots cc7c0fd
Address some feedback
flyingrobots 6e49b02
Address FEEDBACK.md items with tests, code, docs, and CI clarificatio…
flyingrobots e0df337
FEEDBACK.md: mark 'Only reset summary fields for enabled runners' as …
flyingrobots a55be7d
Process new feedback: tighten compliance test, reset summary.core bef…
flyingrobots 82c497f
Mark new FEEDBACK.md items with status+rationale; align notes with im…
flyingrobots 14c1c56
Tell the truth in the header: report writer errors cover invalid inpu…
flyingrobots eda6093
Log: opened tracking issues for parity/polish items
flyingrobots b4611fe
compliance.h: extern C guard + precise NULL/error contracts for runne…
flyingrobots b57538f
Mark latest FEEDBACK.md items with status + rationale (docs, CI, head…
flyingrobots 5e44179
Compliance header: clarify policy/wasm runner semantics (summary-only…
flyingrobots 926beea
FEEDBACK.md: mark all items with status and rationale (header semanti…
flyingrobots 9fe7662
Remove FEEDBACK.md from repo; add guardrails to prevent re-adding\n\n…
flyingrobots d86ae14
Clarify compliance API docs; finish core semantics; strengthen test
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Default code owner for the repo | ||
| # CODEOWNERS only supports GitHub handles; email added as a note. | ||
| * @flyingrobots # james@flyingrobots.dev | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,22 @@ | ||
| # Summary | ||
| ## Summary | ||
|
|
||
| <!-- Briefly describe the change. Link the primary issue and milestone. --> | ||
| Describe the change and why it’s needed. Include links to related issues. | ||
|
|
||
| ## Testing | ||
| ## Checklist | ||
|
|
||
| - [ ] `cmake --build` (debug) | ||
| - [ ] `cmake --build` (release) | ||
| - [ ] `ctest` | ||
| - [ ] `meson compile` (debug) | ||
| - [ ] `meson compile` (release) | ||
| - [ ] `meson test` | ||
| - [ ] Additional checks (lint, docs, etc.): | ||
| - [ ] Tests added/updated | ||
| - [ ] Docs updated (README/docs/ISSUES/ROADMAP) | ||
| - [ ] ACTIVITY.log.jsonl entry added (`make log`) and `make activity-validate` passes | ||
| - [ ] Roadmap/DAG updated if dependencies changed (`make roadmap-validate`) | ||
| - [ ] Containerized targets used (no host builds), per AGENTS.md | ||
|
|
||
| ## Deployment / Release Impact | ||
| ## Acceptance Criteria | ||
|
|
||
| - [ ] No migration needed | ||
| - [ ] Docs updated | ||
| - [ ] Follow-up issues filed | ||
| - [ ] Builds green in CI matrix | ||
| - [ ] Lint/format passes (`make format-check`) | ||
| - [ ] Analyzer (optional) passes (`make analyze`) | ||
|
|
||
| ## Reviewer Checklist | ||
| ## Screenshots/Artifacts (if applicable) | ||
|
|
||
| ## Notes | ||
|
|
||
| - [ ] Includes issue link (e.g., `Closes #123`) | ||
| - [ ] Tests cover new/changed behavior | ||
| - [ ] Dual-build CI expectations satisfied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Compliance (artifact) | ||
|
|
||
| on: | ||
| workflow_dispatch: {} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| compliance: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
| - name: Build (meson) | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install -y ninja-build meson | ||
| meson setup meson-debug --buildtype debugoptimized | ||
| meson compile -C meson-debug | ||
| - name: Emit placeholder compliance report | ||
| run: | | ||
| cat > compliance.json <<'JSON' | ||
| {"implementation":"libgitledger","version":"0.0.0","date":"1970-01-01T00:00:00Z","results":[],"summary":{"core":"PARTIAL","policy":"N/A","wasm":"N/A"}} | ||
| JSON | ||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: compliance.json | ||
| path: compliance.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,3 +67,6 @@ compile_commands.json | |
|
|
||
| # Project-specific | ||
| .obsidian/ | ||
| website/.docusaurus/ | ||
| website/node_modules/ | ||
| FEEDBACK.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "external/ledger-kernel"] | ||
| path = external/ledger-kernel | ||
| url = https://github.com/flyingrobots/ledger-kernel |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Drift Report: libgitledger vs. Ledger‑Kernel Spec | ||
|
|
||
| Date: 2025-11-03T22:48:13Z | ||
|
|
||
| This report compares our current roadmap (issues + DAG) to the Ledger‑Kernel specification in `external/ledger-kernel`. | ||
|
|
||
| ## Inputs | ||
|
|
||
| - Spec repository (submodule): `external/ledger-kernel` | ||
| - Schemas: `schemas/` | ||
| - Compliance: `docs/spec/compliance.md` (C‑1…C‑5 ↔ FS/M) | ||
| - Formal spec: `docs/spec/*.md` (FS‑1…FS‑14, M‑1…M‑9) | ||
| - Roadmap DAG: `docs/ROADMAP-DAG.mmd` (grouped by milestones) | ||
|
|
||
| ## Mapping Summary | ||
|
|
||
| - FS‑10 (Canonical wire format + ID): PARTIAL | ||
| - Roadmap: No explicit issue yet; closest: [M4] libgit2 adapter (I/O), [M3] API docs. | ||
| - Gap: Add issue “Wire format canonicalization + BLAKE3 id (FS‑10)” under M3/M4. | ||
|
|
||
| - FS‑7/FS‑8 (Append-only + ref fast‑forward): PARTIAL | ||
| - Roadmap: Append path (#13), Append enforcement (#19), Policy enforcement tests (#20). | ||
| - Gap: Add explicit non‑FF ref rejection test issue. | ||
|
|
||
| - FS‑11 (Temporal ordering): PARTIAL | ||
| - Roadmap: Ledger lifecycle (#12) + Append/read integration tests (#15). | ||
| - Gap: Add validation test “reject child timestamp < parent”. | ||
|
|
||
| - FS‑3/FS‑9 (Deterministic policy evaluation): N/A (engine not yet present) | ||
| - Roadmap: Policy parser (#17), Policy storage (#16). | ||
| - Gap: Add “Deterministic policy eval harness” issue and seed vectors. | ||
|
|
||
| - FS‑6 (Offline verify end‑to‑end): PARTIAL | ||
| - Roadmap: End‑to‑end tests (#39). | ||
| - Gap: Add small offline replay vector + verifier entrypoint. | ||
|
|
||
| ## Risks / Assumptions | ||
|
|
||
| - BLAKE3 dependency: We will vendor or link a minimal BLAKE3 for FS‑10. | ||
| - WASM policy runtime: Not required for core, mark as N/A until available. | ||
|
|
||
| ## Recommendations | ||
|
|
||
| 1. Create the following issues and link under milestones: | ||
| - [M3] FS‑10 Canonicalization + BLAKE3 id (core) | ||
| - [M2] Non‑FF ref rejection tests (FS‑7/FS‑8) | ||
| - [M2] Timestamp monotonicity validation (FS‑11) | ||
| - [M4] Deterministic policy evaluation harness (FS‑3/FS‑9) | ||
| - [M3] Offline verify minimal replay (FS‑6) | ||
| 2. Add a compliance harness skeleton (report writer + CLI flag) and wire C‑1…C‑3 quickly; mark others N/A. | ||
| 3. Add CI workflow `compliance.yml` in soft mode (artifact only); enable gating on core once C‑1…C‑3 are green. | ||
|
|
||
| ## Next Steps (Implementation Plan) | ||
|
|
||
| - Include headers + source stubs under `include/ledger/` and `src/compliance/`. | ||
| - Add CLI flag `--compliance` (or a small utility) without impacting library ABI. | ||
| - Seed vectors in `tests/vectors/core/`. | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.