Skip to content

Fix misc #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Fix misc #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
835cf8c
refactor(dashboard): Use constants for IDs
fulleni Jul 14, 2025
a9f4cf7
refactor(app_config): Use constant for remote config ID
fulleni Jul 14, 2025
8a438a0
refactor: remove unused imports
fulleni Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/app_configuration/bloc/app_configuration_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:bloc/bloc.dart';
import 'package:equatable/equatable.dart';
import 'package:ht_data_repository/ht_data_repository.dart';
import 'package:ht_shared/ht_shared.dart'; // Use RemoteConfig from ht_shared
import 'package:ht_shared/ht_shared.dart';

part 'app_configuration_event.dart';
part 'app_configuration_state.dart';
Expand All @@ -28,7 +28,7 @@ class AppConfigurationBloc
) async {
emit(state.copyWith(status: AppConfigurationStatus.loading));
try {
final remoteConfig = await _remoteConfigRepository.read(id: 'app_config');
final remoteConfig = await _remoteConfigRepository.read(id: kRemoteConfigId);
emit(
state.copyWith(
status: AppConfigurationStatus.success,
Expand Down
6 changes: 3 additions & 3 deletions lib/dashboard/bloc/dashboard_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:bloc/bloc.dart';
import 'package:equatable/equatable.dart';
import 'package:ht_data_repository/ht_data_repository.dart';
import 'package:ht_shared/ht_shared.dart';
import 'package:ht_shared/ht_shared.dart';

part 'dashboard_event.dart';
part 'dashboard_state.dart';
Expand Down Expand Up @@ -36,8 +36,8 @@ class DashboardBloc extends Bloc<DashboardEvent, DashboardState> {
appConfigResponse,
recentHeadlinesResponse,
] = await Future.wait([
_dashboardSummaryRepository.read(id: 'dashboard_summary'),
_appConfigRepository.read(id: 'app_config'),
_dashboardSummaryRepository.read(id: kDashboardSummaryId),
_appConfigRepository.read(id: kRemoteConfigId),
_headlinesRepository.readAll(
pagination: const PaginationOptions(limit: 5),
sort: const [SortOption('createdAt', SortOrder.desc)],
Expand Down
Loading