Fix/ads article pa pb pa and feed decorator dismiss #192
Conversation
- Deleted the entire .vscode/launch.json file - This file contained configuration settings for different app environments
- Update .gitignore to exclude .vscode/ directory instead of .vscode/* - Remove .vscode/extensions.json file to avoid specific editor recommendations
- Removed mention of pre-configured VS Code launch.json profiles - This change reflects the migration from Flutter to Dart, focusing on making the framework adaptable to various editor environments
…ifecycle management - Remove InlineAdCacheService dependency and cache inline ads within the widget - Simplify ad loading logic by always fetching a new ad when needed - Ensure proper disposal of ad resources when the widget is disposed - Remove contextKey parameter as it's no longer needed - Update widget documentation to reflect new implementation details
- Applied dart fix to the entire file - Adjusted indentation and line breaks - Removed unnecessary whitespace and blank lines - Updated some variable assignments to use shorthand syntax
…testing - Reduce adMaxAge in FeedAdLoaderWidget from 5 minutes to 1 minute - Change interstitial ad countdown in LocalInterstitialAdDialog from 5 seconds to 1 second - These changes allow for more frequent ad refreshes and faster testing of interstitial ad functionality
- Remove PopupMenuButton for dismissal option - Simplify widget structure by removing related callback and logic - Update documentation to reflect changes
…ion decorator - Remove PopupMenuButton for dismiss option - Update widget documentation to reflect removal of dismiss functionality - Remove onDismiss parameter from ContentCollectionDecoratorWidget class
- Remove FeedDecoratorDismissed event from headlines_feed_event.dart - Remove _onFeedDecoratorDismissed handler from headlines_feed_bloc.dart - Remove onDismiss callbacks from headlines_feed_page.dart - Update imports and dependencies related to decorator dismissal
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines ad management by shifting the responsibility for in-article ad lifecycle from a global cache to individual widgets, ensuring more robust resource handling. It also removes the user-facing dismissal option for feed decorators, simplifies the project's VS Code configuration, and includes general code cleanup and formatting improvements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and beneficial refactoring of the in-article ad loading mechanism, moving from a shared cache to a self-contained widget state. This improves lifecycle management and prevents potential state conflicts. Additionally, it removes the ability for users to dismiss feed decorators, which appears to be a deliberate product change. The code is cleaner and more robust as a result. I've identified a few minor areas for improvement, including a potential UI regression in one of the decorator widgets and some code simplification opportunities.
fulleni
deleted the
fix/ads-article-pa-pb-pa-and-feed-decorator-dismiss
branch
Status
READY
Description
This pull request streamlines ad management by shifting the responsibility for in-article ad lifecycle from a global cache to individual widgets, ensuring more robust resource handling. It also removes the user-facing dismissal option for feed decorators, simplifies the project's VS Code configuration, and includes general code cleanup and formatting improvements.
Type of Change