Skip to content

Check for existing results to rebuild #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floydspace merged 2 commits into from
May 5, 2021
Merged

Check for existing results to rebuild #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
162a3b4
Check for existing results to rebuild
anthony-zhou May 2, 2021
33efd2a
refactor: renamed oldResult to result
anthony-zhou May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export class EsbuildPlugin implements Plugin {
}
}

async bundle(incremental = false): Promise<BuildResult[]> {
async bundle(incremental = true): Promise<BuildResult[]> {
this.prepare();
this.serverless.cli.log('Compiling with esbuild...');

Expand All @@ -226,9 +226,16 @@ export class EsbuildPlugin implements Plugin {
delete config['watch'];
delete config['pugins'];

const bundlePath = entry.substr(0, entry.lastIndexOf('.')) + '.js';

if (this.buildResults) {
const { result } = this.buildResults.find(({func: fn}) => fn.name === func.name);
await result.rebuild();
return { result, bundlePath, func };
}

const result = await build(config);

const bundlePath = entry.substr(0, entry.lastIndexOf('.')) + '.js';
return { result, bundlePath, func };
})
).then(results => {
Expand Down