-
Notifications
You must be signed in to change notification settings - Fork 584
refactor: remove MetaInfoHash class #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the artifact hash management by eliminating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good refactoring that removes the unused MetaInfoHash class. The relevant hash constant is moved into the KernelMap class within deep_gemm.py, which is the only place it's used. This improves code organization by increasing locality and removing dead code. The changes are straightforward and correctly implemented. I have one minor suggestion to improve naming for better clarity.
| KERNEL_MAP_HASH = "f161e031826adb8c4f0d31ddbd2ed77e4909e4e43cdfc9728918162a62fcccfb" | ||
|
|
||
| def __init__(self): | ||
| self.indice = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and consistency with the filename kernel_map.json, consider renaming the instance variable indice to kernel_map. This would make it clearer what this variable holds. This change would need to be applied to all usages of self.indice within the KernelMap class.
| self.indice = None | |
| self.kernel_map = None |
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe PR removes the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as deep_gemm user code
participant KernelMap_old as KernelMap (old)
participant Filesystem as kernel_map.json
Note over KernelMap_old: OLD FLOW (before PR)
Caller->>KernelMap_old: KernelMap(sha256=MetaInfoHash.DEEPGEMM)
KernelMap_old->>Filesystem: open(kernel_map.json)
Filesystem-->>KernelMap_old: json data
KernelMap_old->>Filesystem: get_cubin(indice_path, sha256)
Filesystem-->>Caller: validation result
sequenceDiagram
autonumber
participant Caller as deep_gemm user code
participant KernelMap_new as KernelMap (new)
participant Filesystem as kernel_map.json
Note over KernelMap_new: NEW FLOW (this PR)
Caller->>KernelMap_new: KernelMap()
KernelMap_new->>Filesystem: open(kernel_map.json)
Filesystem-->>KernelMap_new: json data
KernelMap_new->>Filesystem: get_cubin(indice_path, KERNEL_MAP_HASH)
Filesystem-->>Caller: validation result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📌 Description
This class is not required after @jimmyzho 's refactor work in https://github.com/flashinfer-ai/flashinfer/pull/1967/files, and the only remaining pieces requiring its value is deepgemm (because of different artifact structure, deepgemm only have a kernel_map.json instead of header file).
In this PR we remove the class
MetaInfoHashto stop people further updating its content, and move the special case kernel map hash to deepgemm.py .🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
cc @jimmyzho @cyx-6
Summary by CodeRabbit