replay: improve reliability of replay to tower vote states sending

[topointon-jump]

Eliminate several failure modes when sending vote accounts from replay->tower.

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.06363 s	0.063782 s	0.239% ✅
backtest mainnet-368528500-perf snapshot load	2.146 s	2.14 s	-0.280% ✅
backtest mainnet-368528500-perf total elapsed	63.630275 s	63.78239 s	0.239% ✅
firedancer mem usage with mainnet.toml	1024.14 GiB	1024.14 GiB	0.000% ✅

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.074302 s	0.170018 s	128.820% ⚠️
backtest mainnet-368528500-perf snapshot load	2.659 s	2.647 s	-0.451% ✅
backtest mainnet-368528500-perf total elapsed	74.301883 s	170.018185 s	128.821% ⚠️
firedancer mem usage with mainnet.toml	991.14 GiB	991.14 GiB	0.000% ✅

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.052729 s	0.052166 s	-1.068% ✅
backtest mainnet-368528500-perf snapshot load	1.707 s	1.659 s	-2.812% ✅
backtest mainnet-368528500-perf total elapsed	52.729387 s	52.165898 s	-1.069% ✅
firedancer mem usage with mainnet.toml	991.14 GiB	991.14 GiB	0.000% ✅

[ibhatt-jumptrading]

i was thinking about this a little bit, we could just cross reference with the current vote states because that stays up to date so if an account is not in vote_states but is in vote_states_prev, we get rid of it. So I propose we just add stakes_t_1 to fd_vote_states.c/h. This makes it so we can reliably just reference the current vote states for the source of truth and don't need to rely on funk failure modes or introspecting on the actual account data. This should be a quick fix: you just need to copy how the vote states has the stake values from t-2

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.073011 s	0.073088 s	0.105% ✅
backtest mainnet-368528500-perf snapshot load	2.686 s	2.694 s	0.298% ✅
backtest mainnet-368528500-perf total elapsed	73.011141 s	73.088259 s	0.106% ✅
firedancer mem usage with mainnet.toml	991.14 GiB	992.14 GiB	0.101% ✅

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.060051 s	0.051055 s	-14.981% ✅
backtest mainnet-368528500-perf snapshot load	1.782 s	1.376 s	-22.783% ✅
backtest mainnet-368528500-perf total elapsed	60.050677 s	51.055305 s	-14.980% ✅
firedancer mem usage with mainnet.toml	991.14 GiB	992.14 GiB	0.101% ✅

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.072978 s	0.073203 s	0.308% ✅
backtest mainnet-368528500-perf snapshot load	2.696 s	2.653 s	-1.595% ✅
backtest mainnet-368528500-perf total elapsed	72.977749 s	73.203475 s	0.309% ✅
firedancer mem usage with mainnet.toml	991.14 GiB	992.14 GiB	0.101% ✅

[topointon-jump]

updated this so that fd_replay_out_vote_tower_from_funk can never fail (cc @ibhatt-jumptrading @mmcgee-jump)