solcap v2: updates to solcap #6829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
2 times, most recently
from
8608f30 to
3b04448
Compare
nipatel-jump
changed the title
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
10 times, most recently
from
7377f26 to
2a98888
Compare
nipatel-jump
changed the title
nipatel-jump
changed the title
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
5 times, most recently
from
6c695ee to
f9377e0
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
f9377e0 to
e8dbf07
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
e8dbf07 to
3840d97
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
3840d97 to
a0970ba
Compare
Performance Measurements ⏳
|
Contributor
ibhatt-jumptrading
left a comment
ibhatt-jumptrading
left a comment
There was a problem hiding this comment.
logic looks good, just need to clean up the code
i don't have enough expertise to review the stem changes
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
a0970ba to
32f4b21
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
0a4f99e to
a484fbb
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
a484fbb to
1a97cfa
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
1a97cfa to
00e1be2
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
00e1be2 to
d5b7148
Compare
Performance Measurements ⏳
|
nipatel-jump
force-pushed
the
nishk/solcap_new
branch
from
710f6e4 to
d5b7148
Compare
mmcgee-jump
reviewed
Nov 14, 2025
| "type": "struct", | ||
| "fields": [ | ||
| { "name": "lamports", "type": "ulong" }, | ||
| { "name": "rent_epoch", "type": "ulong" }, |
mmcgee-jump
reviewed
Nov 14, 2025
| /* Add the capture tile to topo */ | ||
| /**********************************************************************/ | ||
| if (solcap_enabled) { | ||
| fd_topob_wksp( topo, "captur" ); |
Contributor
There was a problem hiding this comment.
Why do you need to capture anything in backtest?
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
| .slot = (uint32_t)msg_hdr->slot, | ||
| .txn_idx = msg_hdr->txn_idx | ||
| }; | ||
| fwrite( &int_hdr, sizeof(fd_solcap_chunk_int_hdr_t), 1UL, file ); |
Contributor
There was a problem hiding this comment.
Need error code checking everywhere for stuff like this, even just FD_TEST the result is not err
Contributor
Author
There was a problem hiding this comment.
That is in one of the commits on the other branch which i will squash into this commit after fixing comments from this review.
mmcgee-jump
reviewed
Nov 14, 2025
| sizeof(fd_solcap_chunk_ftr_t)); | ||
|
|
||
| /* Serialize account chunk metadata */ | ||
| uint32_t block_len = (uint32_t)((unaligned_block_len + 3UL) & ~3UL); |
Contributor
There was a problem hiding this comment.
Suggested change
| uint32_t block_len = (uint32_t)((unaligned_block_len + 3UL) & ~3UL); | |
| uint block_len = (uint)((unaligned_block_len + 3UL) & ~3UL); |
Use fd types everywhere please
mmcgee-jump
reviewed
Nov 14, 2025
|
|
||
| ctx->gui_enabled = fd_topo_find_tile( topo, "gui", 0UL )!=ULONG_MAX; | ||
|
|
||
| if( FD_UNLIKELY( strcmp( "", tile->replay.solcap_capture ) ) ) { |
Contributor
There was a problem hiding this comment.
What is any of this for? It does not look like it's used
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
| fd_solcap_write_ftr( ctx->capture_ctx->capture, ctx->block_len ); | ||
|
|
||
| if (ctx->msg_set_sig == SOLCAP_WRITE_BANK_PREIMAGE) { | ||
| fflush(ctx->file); |
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
mmcgee-jump
reviewed
Nov 14, 2025
| writer->account_idx = 0UL; | ||
| return 0; | ||
| FILE* | ||
| fd_solcap_file_verify( fd_solcap_writer_t * writer ) { |
mmcgee-jump
reviewed
Nov 14, 2025
|
|
||
| ctl = fd_frag_meta_ctl( 0UL, 0UL, is_last ? 1UL : 0UL, 0UL ); | ||
|
|
||
| fd_mcache_publish( buf->mcache, buf->depth, buf->seq, 0UL, buf->chunk, msg_sz, ctl, 0UL, 0UL ); |
Contributor
There was a problem hiding this comment.
you can just send the sz here
mmcgee-jump
reviewed
Nov 14, 2025
| ulong slot, | ||
| uchar const * data, | ||
| ulong data_sz) { | ||
| ctx->capture_link->vt->write_account_update(ctx, txn_idx, key, info, slot, data, data_sz); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Solcap Version