-
Notifications
You must be signed in to change notification settings - Fork 366
snapshots: lthash #5954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
snapshots: lthash #5954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1962ac8 to
40a602b
Compare
cf0495e to
fd5559d
Compare
a634319 to
766d347
Compare
560192f to
1006736
Compare
mmcgee-jump
reviewed
Sep 18, 2025
e2da3cc to
8f53963
Compare
mmcgee-jump
reviewed
Sep 18, 2025
src/discof/restore/fd_snaplt_tile.c
Outdated
| case FD_SNAPSHOT_HASH_MSG_SUB: { | ||
| FD_TEST( ctx->state==FD_SNAPLT_STATE_HASHING ); | ||
|
|
||
| fd_snapshot_existing_account_t * prev_acc = (fd_snapshot_existing_account_t *)fd_chunk_to_laddr_const( ctx->in.wksp, chunk ); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| fd_snapshot_existing_account_t * prev_acc = (fd_snapshot_existing_account_t *)fd_chunk_to_laddr_const( ctx->in.wksp, chunk ); | |
| fd_snapshot_existing_account_t const * prev_acc = fd_chunk_to_laddr_const( ctx->in.wksp, chunk ); |
8f53963 to
620fa32
Compare
mmcgee-jump
requested changes
Sep 18, 2025
6fb4911 to
87afbc8
Compare
87afbc8 to
1993e59
Compare
Contributor
Author
|
superseded by #7064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds snapshot hashing tiles. They are disabled by default but enabled in CI to verify the snapshot lthash in ledgers. We plan to enable them by default once their performance can keep up with download speed.