feat: remaining seconds for startup phases #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
asuzuki-jumptrading
commented
Nov 27, 2025
asuzuki-jumptrading
commented
- add remaining second estimates for startup phases
- gossip: peer count / 5000 for completion %
- snapshots: insert completed / total for completion %
- catching up: use replay rate and number of slots left to replay. Use useEma hook
asuzuki-jumptrading
requested review from
amliu-jumptrading and
atsai-jumptrading
| return true; | ||
| }); | ||
|
|
||
| export const bootProgressBarPctAtom = atom((get) => { |
Collaborator
Author
There was a problem hiding this comment.
Calculations are moved into individual phase components
asuzuki-jumptrading
force-pushed
the
asuzuki/startup-header-phase
branch
2 times, most recently
from
1f16300 to
b694597
Compare
atsai-jumptrading
approved these changes
Dec 2, 2025
amliu-jumptrading
approved these changes
Dec 2, 2025
| <GossipCard | ||
| title="Staked Peers" | ||
| value={health.connected_staked_peers} | ||
| value={health.connected_staked_peers.toLocaleString(undefined, { |
Collaborator
There was a problem hiding this comment.
Should we add a zeroDecimalFormatter in the numUtils and import that like we do with the compactZeroDecimalFormatter
Collaborator
Author
There was a problem hiding this comment.
I think we can leave this one as is because it's a method called on the value rather than a util function accepting an independent value. It also doesn't need special treatment like making the value compact.
asuzuki-jumptrading
force-pushed
the
asuzuki/startup-header-phase
branch
from
b694597 to
45a9e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.