Skip to content

wrap off(firebaseQuery, 'value', valueUnsubscribe) in setTimeout-0 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wrap off(firebaseQuery, 'value', valueUnsubscribe) in setTimeout-0 #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e61ac
wrap call to off(firebaseQuery, 'value', valueUnsubscribe) in a setTi…
tobias74 Oct 26, 2024
3f54951
use the unsubscribe function correctly
tobias74 Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/geofire/src/GeoQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,10 @@ export class GeoQuery {
// and, if so, mark the value event as fired.
// Note that Firebase fires the 'value' event after every 'child_added' event fires.
const valueUnsubscribe = onValue(firebaseQuery, () => {
off(firebaseQuery, 'value', valueUnsubscribe);
this._geohashQueryReadyCallback(toQueryStr);
setTimeout(() => {
valueUnsubscribe();
this._geohashQueryReadyCallback(toQueryStr);
}, 0);
});

// Add the geohash query to the current geohashes queried dictionary and save its state
Expand Down