Update Windows runner in build_windows action to windows-latest (from windows-2019) (#1261)

* Change windows-2019 runner to windows-latest.

* Update libz removal path.

* Update VS version for Windows build.

* Change .NET version.

Author: jonsimantov

.github/workflows/build_windows.yml

@@ -40,7 +40,7 @@ permissions: write-all
 jobs:
   build_desktop:
     name: build-windows-unity${{inputs.unity_version}}-CPP${{ inputs.firebase_cpp_sdk_version }}
-    runs-on: windows-2019
+    runs-on: windows-latest
     strategy:
       fail-fast: false
 
@@ -108,13 +108,15 @@ jobs:
       - name: Remove zlib
         shell: bash
         run: |
-          rm C:/msys64/mingw64/lib/libz*
+          rm -f C:/mingw32/i686-w64-mingw32/lib/libz*
+          rm -f C:/mingw64/x86_64-w64-mingw32/lib/libz*
+          rm -f C:/msys64/mingw64/lib/libz*
 
       # Strawberry Perl has zlib within, so we also remove it
       - name: Remove Strawberry
         shell: bash
         run: |
-          rm -r C:/Strawberry
+          rm -rf C:/Strawberry
       
       - name: Build SDK (Windows)
         timeout-minutes: 90

cmake/unity_mono.cmake

@@ -204,7 +204,7 @@ endmacro()
 #  sys_references: System CSharp libraries this depends on
 #  dep_targets: Targets this target depends on and need to be linked/built first
 #  guid: MSBuild project guid (for use with solution files)
-#  framework_version: .net framework version, defaults to 4.5
+#  framework_version: .net framework version, defaults to 4.7.2
 #  defines: Extra defines to add to the project file
 #  assembly_name: Name of the output assembly. Defaults to module
 #  xbuild: Path to xbuild executable. Defaults to XBUILD_EXE global var
@@ -259,7 +259,7 @@ macro(mono_add_internal name output_type)
   endif()
 
   if ("${UNITY_MONO_FRAMEWORK_VERSION}" STREQUAL "")
-    set(UNITY_MONO_FRAMEWORK_VERSION "4.5")
+    set(UNITY_MONO_FRAMEWORK_VERSION "4.7.2")
   endif()
 
   if ("${UNITY_MONO_ASSEMBLY_NAME}" STREQUAL "")

scripts/build_scripts/build_zips.py

@@ -430,7 +430,7 @@ def get_windows_args():
       cmake args for windows platform.
   """
   result_args = []
-  result_args.append('-G Visual Studio 16 2019')
+  result_args.append('-G Visual Studio 17 2022')
   result_args.append('-A x64') # TODO flexibily for x32
   result_args.append("-DFIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=%s" % sys.executable)
   # Use a newer version of the Windows SDK, as the default one has build issues with grpc