Set Android common page size to 16 KB (#1260)

a-maurice · web-flow · commit 63ac2b129c8e · 2025-06-03T16:43:03.000-07:00
* Set common page size to 16kb

* Update readme.md
diff --git a/cmake/build_shared.cmake b/cmake/build_shared.cmake
@@ -108,6 +108,7 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)
         "-static-libstdc++"
         # Set the max page size to 16KB, needed by Android 15
         "-Wl,-z,max-page-size=16384"
+        "-Wl,-z,common-page-size=16384"
     )
     add_custom_command(TARGET ${shared_target} POST_BUILD
       COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose
diff --git a/cmake/build_universal.cmake b/cmake/build_universal.cmake
@@ -88,6 +88,7 @@ function(build_uni TARGET_LINK_LIB_NAMES PROJECT_LIST_HEADER_VARIABLE)
         "-static-libstdc++"
         # Set the max page size to 16KB, needed by Android 15
         "-Wl,-z,max-page-size=16384"
+        "-Wl,-z,common-page-size=16384"
     )
     add_custom_command(TARGET firebase_app_uni POST_BUILD
       COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose
diff --git a/docs/readme.md b/docs/readme.md
@@ -71,6 +71,11 @@ Support
 
 Release Notes
 -------------
+### Upcoming
+-   Changes
+    - General (Android): Fix a crash with 16 KB page sizes.
+      ([#1259](https://github.com/firebase/firebase-unity-sdk/issues/1259)).
+
 ### 12.9.0
 -   Changes
     - General: Update to EDM4U version 1.2.186.

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)`
`108`	`108`	`"-static-libstdc++"`
`109`	`109`	`# Set the max page size to 16KB, needed by Android 15`
`110`	`110`	`"-Wl,-z,max-page-size=16384"`
	`111`	`+ "-Wl,-z,common-page-size=16384"`
`111`	`112`	`)`
`112`	`113`	`add_custom_command(TARGET ${shared_target} POST_BUILD`
`113`	`114`	`COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose`
Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ function(build_uni TARGET_LINK_LIB_NAMES PROJECT_LIST_HEADER_VARIABLE)`
`88`	`88`	`"-static-libstdc++"`
`89`	`89`	`# Set the max page size to 16KB, needed by Android 15`
`90`	`90`	`"-Wl,-z,max-page-size=16384"`
	`91`	`+ "-Wl,-z,common-page-size=16384"`
`91`	`92`	`)`
`92`	`93`	`add_custom_command(TARGET firebase_app_uni POST_BUILD`
`93`	`94`	`COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose`