-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Replace hosting with deploy prompt in init command #9570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @charlotteliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the guidance provided within the backend initialization process by adjusting how deployment is presented. It removes the specific instruction to set up Firebase Hosting as part of the initial service configuration. Instead, it introduces a more general recommendation to use a deploy prompt for application deployment once the core services like Firestore and Authentication are configured, aiming to streamline the initial setup experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the backend initialization guide by removing the explicit step for setting up Hosting and instead pointing the user towards using a deploy prompt. The change is good, but it leaves a conflicting instruction about deployment. I've added a comment to resolve this ambiguity.
joehan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts on this. Additonally, can you include some evidence that this works in the PR description?
Tested locally that it no longer retrieves hosting guide and directed to app hosting prompt successfully