Improve error message for reserved environment variables #9561
Conversation
Modified `src/functions/env.ts` to provide clearer error messages when users define reserved environment variables in their `.env` files. - Updated `validateKey` to include the specific reserved prefix that caused the error. - Updated `loadUserEnvs` to bubble up validation error details in the main `FirebaseError` message. - Updated tests to match the new behavior. Addresses #5833
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Modified `src/functions/env.ts` to provide clearer error messages when users define reserved environment variables in their `.env` files. - Updated `validateKey` to include the specific reserved prefix that caused the error. - Updated `loadUserEnvs` to bubble up validation error details in the main `FirebaseError` message. - Updated tests to match the new behavior. - Reverted unintentional changes to `npm-shrinkwrap.json`. Addresses #5833
1 participant
This change improves the error message when a reserved environment variable (e.g.,
PORT,FIREBASE_PROJECT_ID) is used in a.envfile. Previously, the CLI would crash with a generic "Failed to load environment variables from .env" error, hiding the specific cause. Now, it explicitly lists the reserved key and explains why it is reserved.PR created automatically by Jules for task 6640636309332153565 started by @joehan