Fix trusted types violation in packages/auth/src/platform_browser/index.ts #9402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a Trusted Types violation in the
loadJSfunction. The violation occurs because a URL constructed from a string is used to set thesrcattribute of a script element, which is a potential DOM XSS vulnerability.The patch resolves this issue by using
safevalues.safeUrlto create aSafeUrlobject from the URL string. This sanitized URL is then used with thesafevalues.dom.setSrcfunction to safely set thesrcattribute of the script element. This ensures that only sanitized, trusted URLs can be loaded, thus mitigating the risk of DOM XSS attacks.This change is purely for security and has no functional impact.
Test: Verified that all existing tests pass after the change.