When printing libsecret errors on Linux, suppress the error if the same one

happens multiple times in a row. The user only needs to see it once.

PiperOrigin-RevId: 290152261

Author: jonsimantov

app/src/secure/user_secure_linux_internal.cc

@@ -47,7 +47,7 @@ SecretSchema BuildSchema(const char key_namespace[]) {
 
 UserSecureLinuxInternal::UserSecureLinuxInternal(const char* domain,
                                                  const char* key_namespace)
-    : domain_(domain), key_namespace_(key_namespace) {
+    : domain_(domain), key_namespace_(key_namespace), known_error_code_(0) {
   storage_schema_ = BuildSchema(key_namespace_.c_str());
 }
 
@@ -68,14 +68,8 @@ std::string UserSecureLinuxInternal::LoadUserData(const std::string& app_name) {
       /* key1= */ kAppNameKey,
       /* value1= */ app_name.c_str(), /* key2= */ kStorageDomainKey,
       /* value2= */ domain_.c_str(), nullptr);
-  if (error) {
-    LogWarning("Secret lookup failed. Error %d: %s", error->code,
-               error->message);
-    g_error_free(error);
-    return empty_str;
-  }
 
-  if (result == nullptr) {
+  if (CheckForError(&error, "lookup") || result == nullptr) {
     return empty_str;
   }
   std::string str_result(result);
@@ -97,11 +91,7 @@ void UserSecureLinuxInternal::SaveUserData(const std::string& app_name,
       /* value1= */ app_name.c_str(),
       /* key2= */ kStorageDomainKey, /* value2= */ domain_.c_str(), nullptr);
 
-  if (error) {
-    LogWarning("Secret store failed. Error %d: %s", error->code,
-               error->message);
-    g_error_free(error);
-  }
+  CheckForError(&error, "store");
 }
 
 void UserSecureLinuxInternal::DeleteUserData(const std::string& app_name) {
@@ -116,11 +106,7 @@ void UserSecureLinuxInternal::DeleteUserData(const std::string& app_name) {
                              /* key2= */ kStorageDomainKey,
                              /* value2= */ domain_.c_str(), nullptr);
 
-  if (error) {
-    LogWarning("Secret clear failed. Error %d: %s", error->code,
-               error->message);
-    g_error_free(error);
-  }
+  CheckForError(&error, "clear");
 }
 
 void UserSecureLinuxInternal::DeleteAllData() {
@@ -132,11 +118,20 @@ void UserSecureLinuxInternal::DeleteAllData() {
                              /* error= */ &error,
                              /* key2= */ kStorageDomainKey,
                              /* value2= */ domain_.c_str(), nullptr);
-  if (error) {
-    LogWarning("Secret clear failed. Error %d: %s", error->code,
-               error->message);
-    g_error_free(error);
+  CheckForError(&error, "clear");
+}
+
+bool UserSecureLinuxInternal::CheckForError(GError** error,
+                                            const char* function_name) {
+  if (error == nullptr || *error == nullptr) return false;
+  if ((*error)->code != known_error_code_) {
+    LogWarning("Secret %s failed. Error %d: %s", function_name, (*error)->code,
+               (*error)->message);
+    known_error_code_ = (*error)->code;
   }
+  g_error_free(*error);
+  *error = nullptr;
+  return true;
 }
 
 }  // namespace secure

app/src/secure/user_secure_linux_internal.h

@@ -45,9 +45,15 @@ class UserSecureLinuxInternal : public UserSecureInternal {
   void DeleteAllData() override;
 
  private:
+  // Check if there is an error, log it and free it if there is.
+  // Returns true iff there was an error.
+  bool CheckForError(GError** error, const char* function_name);
+
   const std::string domain_;
   const std::string key_namespace_;
   SecretSchema storage_schema_;
+  int known_error_code_;  // If nonzero, this error was already logged, so
+                          // don't be too spammy about it.
 };
 
 }  // namespace secure