[RemoteConfig] Android impl

PiperOrigin-RevId: 290107855

Author: cynthiajiang

remote_config/src/android/remote_config_android.cc

@@ -16,7 +16,10 @@
 #define FIREBASE_REMOTE_CONFIG_CLIENT_CPP_SRC_ANDROID_REMOTE_CONFIG_ANDROID_H_
 
 #include "firebase/app.h"
+#include "app/src/mutex.h"
+#include "app/src/reference_count.h"
 #include "app/src/reference_counted_future_impl.h"
+#include "app/src/util_android.h"
 #include "firebase/future.h"
 #include "remote_config/src/include/firebase/remote_config.h"
 
@@ -76,20 +79,38 @@ class RemoteConfigInternal {
 
   std::map<std::string, Variant> GetAll();
 
-  const ConfigInfo& GetInfo() const;
+  const ConfigInfo GetInfo() const;
 
   bool Initialized() const;
 
   void Cleanup();
 
+  void set_throttled_end_time(int64_t end_time) {
+    throttled_end_time_ = end_time;
+  }
+
+  void SaveTmpKeysToDefault(std::vector<std::string> tmp_default_keys) {
+    MutexLock lock(default_key_mutex_);
+    default_keys_ = std::move(tmp_default_keys);
+  }
+
  private:
+  static firebase::internal::ReferenceCount initializer_;
   // app
   const firebase::App& app_;
 
   /// Handle calls from Futures that the API returns.
   ReferenceCountedFutureImpl future_impl_;
 
-  jobject* internal_obj_;
+  jobject internal_obj_;
+
+  Mutex default_key_mutex_;
+  std::vector<std::string> tmp_default_keys_;
+  std::vector<std::string> default_keys_;
+
+  // If a fetch was throttled, this is set to the time when throttling is
+  // finished, in milliseconds since epoch.
+  int64_t throttled_end_time_ = 0;
 };
 
 }  // namespace internal

remote_config/src/android/remote_config_android.h

@@ -30,14 +30,14 @@ enum RemoteConfigFn {
   kRemoteConfigFnCount
 };
 
-/// @brief Describes the error codes returned by fetch futures.
-enum FetchFutureStatus {
+/// @brief Describes the error codes returned by futures.
+enum FutureStatus {
   // The future returned successfully.
   // This should always evaluate to zero, to ensure that the future returns
   // a zero result on success.
-  kFetchFutureStatusSuccess = 0,
+  kFutureStatusSuccess = 0,
   // The future returned unsuccessfully.  Check GetInfo() for further details.
-  kFetchFutureStatusFailure,
+  kFutureStatusFailure,
 };
 
 // Data structure which holds the Future API implementation with the only

remote_config/src/common.h

@@ -443,7 +443,7 @@ bool RemoteConfigInternal::ActivateFetched() {
   return true;
 }
 
-const ConfigInfo& RemoteConfigInternal::GetInfo() const {
+const ConfigInfo RemoteConfigInternal::GetInfo() const {
   std::unique_lock<std::mutex> lock(mutex_);
   return configs_.metadata.info();
 }
@@ -480,9 +480,10 @@ void RemoteConfigInternal::AsyncFetch() {
 
         is_fetch_process_have_task_ = false;
       }
-      FetchFutureStatus futureResult =
+      FutureStatus futureResult =
           (GetInfo().last_fetch_status == kLastFetchStatusSuccess)
-          ? kFetchFutureStatusSuccess : kFetchFutureStatusFailure;
+              ? kFutureStatusSuccess
+              : kFutureStatusFailure;
 
       FutureData* future_data = FutureData::Get();
       future_data->api()->Complete(handle, futureResult);

remote_config/src/desktop/remote_config_desktop.cc

@@ -116,7 +116,7 @@ class RemoteConfigInternal {
 
   bool ActivateFetched();
 
-  const ConfigInfo& GetInfo() const;
+  const ConfigInfo GetInfo() const;
 
   static bool IsBoolTrue(const std::string& str);
   static bool IsBoolFalse(const std::string& str);

remote_config/src/desktop/remote_config_desktop.h

@@ -150,7 +150,8 @@ bool ActivateFetched() {
 const ConfigInfo& GetInfo() {
   static ConfigInfo config_info;
   FIREBASE_ASSERT_RETURN(config_info, internal::IsInitialized());
-  return g_remote_config_desktop_instance->GetInfo();
+  config_info = g_remote_config_desktop_instance->GetInfo();
+  return config_info;
 }
 
 Future<void> Fetch() { return Fetch(kDefaultCacheExpiration); }

remote_config/src/desktop/remote_config_legacy.cc

@@ -726,7 +726,7 @@ class RemoteConfig {
   ///
   /// @return A ConfigInfo struct, containing fields reflecting the state
   /// of the most recent fetch request.
-  const ConfigInfo& GetInfo();
+  const ConfigInfo GetInfo();
 
   /// Gets the App this remote config object is connected to.
   App* app() { return app_; }
@@ -751,7 +751,7 @@ class RemoteConfig {
   static RemoteConfig* FindRemoteConfig(App* app);
 
   // Clean up RemoteConfig instance.
-  static void DeleteInternal(RemoteConfig* rc);
+  void DeleteInternal();
 
   /// The Firebase App this remote config is connected to.
   App* app_;

remote_config/src/include/firebase/remote_config.h

@@ -73,7 +73,7 @@ class RemoteConfigInternal {
 
   std::map<std::string, Variant> GetAll();
 
-  const ConfigInfo& GetInfo() const;
+  const ConfigInfo GetInfo() const;
 
   bool Initialized() const;
 

remote_config/src/ios/remote_config_ios.h

@@ -321,14 +321,13 @@ static void CheckDoubleConversion(FIRRemoteConfigValue *value, ValueInfo *info)
             ((NSNumber *)error.userInfo[FIRRemoteConfigThrottledEndTimeInSecondsKey]);
       }
       // If we got an error code back, return that, with the associated string.
-      api->Complete(handle, kFetchFutureStatusFailure,
+      api->Complete(handle, kFutureStatusFailure,
                     util::NSStringToString(error.localizedDescription).c_str());
     } else if (status != FIRRemoteConfigFetchStatusSuccess) {
-          api->Complete(handle, kFetchFutureStatusFailure,
-                        "Fetch encountered an error.");
+      api->Complete(handle, kFutureStatusFailure, "Fetch encountered an error.");
     } else {
       // Everything worked!
-      api->Complete(handle, kFetchFutureStatusSuccess);
+      api->Complete(handle, kFutureStatusSuccess);
     }
   };
   [g_remote_config_instance fetchWithExpirationDuration:cache_expiration_in_seconds
@@ -522,8 +521,8 @@ bool ActivateFetched() {
   return value;
 }
 
-const ConfigInfo& RemoteConfigInternal::GetInfo() const {
-  static ConfigInfo config_info;
+const ConfigInfo RemoteConfigInternal::GetInfo() const {
+  ConfigInfo config_info;
   // TODO(cynthiajiang) implement
   return config_info;
 }

remote_config/src/ios/remote_config_ios.mm

@@ -58,14 +58,16 @@ RemoteConfig* RemoteConfig::GetInstance(App* app) {
           "it depends upon.",
           static_cast<int>(reinterpret_cast<intptr_t>(rc)),
           static_cast<int>(reinterpret_cast<intptr_t>(rc->app())));
-      DeleteInternal(rc);
+      rc->DeleteInternal();
     });
+
+    // Stick it in the global map so we remember it, and can delete it on
+    // shutdown.
+    g_rcs[app] = rc;
+    return rc;
   }
 
-  // Stick it in the global map so we remember it, and can delete it on
-  // shutdown.
-  g_rcs[app] = rc;
-  return rc;
+  return nullptr;
 }
 
 RemoteConfig* RemoteConfig::FindRemoteConfig(App* app) {
@@ -78,18 +80,20 @@ RemoteConfig* RemoteConfig::FindRemoteConfig(App* app) {
   return nullptr;
 }
 
-void RemoteConfig::DeleteInternal(RemoteConfig* rc) {
+void RemoteConfig::DeleteInternal() {
   MutexLock lock(g_rc_mutex);
+  if (!internal_) return;
 
-  CleanupNotifier* notifier = CleanupNotifier::FindByOwner(rc->app());
+  CleanupNotifier* notifier = CleanupNotifier::FindByOwner(app());
   assert(notifier);
-  notifier->UnregisterObject(rc);
+  notifier->UnregisterObject(this);
 
-  // Remove rc from the g_rcs map.
-  g_rcs.erase(rc->app());
+  internal_->Cleanup();
+  delete internal_;
+  internal_ = nullptr;
 
-  delete rc;
-  rc = nullptr;
+  // Remove rc from the g_rcs map.
+  g_rcs.erase(app());
 }
 
 RemoteConfig::RemoteConfig(App* app) {
@@ -98,11 +102,7 @@ RemoteConfig::RemoteConfig(App* app) {
   internal_ = new internal::RemoteConfigInternal(*app);
 }
 
-RemoteConfig::~RemoteConfig() {
-  internal_->Cleanup();
-  delete internal_;
-  internal_ = nullptr;
-}
+RemoteConfig::~RemoteConfig() { DeleteInternal(); }
 
 bool RemoteConfig::InitInternal() { return internal_->Initialized(); }
 
@@ -199,9 +199,7 @@ std::string RemoteConfig::GetString(const char* key, ValueInfo* info) {
 }
 
 std::vector<unsigned char> RemoteConfig::GetData(const char* key) {
-  std::vector<unsigned char> value;
-  // TODO(cynthiajiang) implement
-  return value;
+  return GetData(key, static_cast<ValueInfo*>(nullptr));
 }
 
 std::vector<unsigned char> RemoteConfig::GetData(const char* key,
@@ -222,9 +220,7 @@ std::map<std::string, Variant> RemoteConfig::GetAll() {
 }
 
 // TODO(b/147143718): Change to a more descriptive name.
-const ConfigInfo& RemoteConfig::GetInfo() {
-  return internal_->GetInfo();
-}
+const ConfigInfo RemoteConfig::GetInfo() { return internal_->GetInfo(); }
 #endif  // FIREBASE_EARLY_ACCESS_PREVIEW
 
 }  // namespace remote_config