Change GetGooglePlayServices to use reflection to avoid build errors (#1238)

Author: jonsimantov

analytics/integration_test/src/integration_test.cc

@@ -108,7 +108,7 @@ TEST_F(FirebaseAnalyticsTest, TestGetAnalyticsInstanceID) {
 
 TEST_F(FirebaseAnalyticsTest, TestGetSessionID) {
   // Don't run this test if Google Play services is < 23.0.0.
-  SKIP_TEST_ON_ANDROID_GOOGLE_PLAY_SERVICES_BELOW(230000);
+  SKIP_TEST_ON_ANDROID_IF_GOOGLE_PLAY_SERVICES_IS_OLDER_THAN(230000);
 
   // iOS simulator tests are currently extra flaky, occasionally failing with an
   // "Analytics uninitialized" error even after multiple attempts.

testing/test_framework/src/android/java/com/google/firebase/example/TestHelper.java

@@ -16,7 +16,10 @@
 
 import android.content.Context;
 import android.os.Build;
-import com.google.android.gms.common.GoogleApiAvailability;
+import android.util.Log;
+import java.lang.Class;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 
 /**
  * A simple class with test helper methods.
@@ -31,6 +34,28 @@ public static boolean isRunningOnEmulator() {
         || Build.DEVICE.contains("vbox86p") || Build.HARDWARE.contains("vbox86");
   }
   public static int getGooglePlayServicesVersion(Context context) {
-    return GoogleApiAvailability.getInstance().getApkVersion(context);
+    // Use reflection to return GoogleApiAvailability.getInstance().getApkVersion(context);
+    // This avoids needing Google Play services to be present (and returns 0 if it's not).
+    try {
+      // GoogleApiAvailability
+      Class<?> googleApiAvailabilityClass =
+          Class.forName("com.google.android.gms.common.GoogleApiAvailability");
+
+      // .getInstance()
+      Method getInstanceMethod = googleApiAvailabilityClass.getDeclaredMethod("getInstance");
+      Object instance = getInstanceMethod.invoke(null);
+
+      // .getApkVersion(context)
+      Class[] getApkVersionParams = new Class[] {Class.forName("android.content.Context")};
+      Method getApkVersionMethod =
+          googleApiAvailabilityClass.getMethod("getApkVersion", getApkVersionParams);
+      Object apkVersionObject = getApkVersionMethod.invoke(instance, context);
+      if (apkVersionObject != null && apkVersionObject instanceof Integer) {
+        return ((Integer) apkVersionObject).intValue();
+      }
+    } catch (Exception e) {
+      Log.e(TAG, e.toString());
+    }
+    return 0;
   }
 }

testing/test_framework/src/firebase_test_framework.h

@@ -88,6 +88,7 @@ namespace firebase_test_framework {
 // SKIP_TEST_ON_MACOS
 // SKIP_TEST_ON_SIMULATOR / SKIP_TEST_ON_EMULATOR (identical)
 // SKIP_TEST_ON_IOS_SIMULATOR / SKIP_TEST_ON_ANDROID_EMULATOR
+// SKIP_TEST_ON_ANDROID_IF_GOOGLE_PLAY_SERVICES_IS_OLDER_THAN(version_code)
 //
 // Also includes a special macro SKIP_TEST_IF_USING_STLPORT if compiling for
 // Android STLPort, which does not fully support C++11.
@@ -206,7 +207,7 @@ namespace firebase_test_framework {
 #endif
 
 #if defined(ANDROID)
-#define SKIP_TEST_ON_ANDROID_GOOGLE_PLAY_SERVICES_BELOW(x)                \
+#define SKIP_TEST_ON_ANDROID_IF_GOOGLE_PLAY_SERVICES_IS_OLDER_THAN(x)     \
   {                                                                       \
     int _required_ver_ = (x);                                             \
     /* Example: 23.1.2 has version code 230102???. */                     \
@@ -215,7 +216,7 @@ namespace firebase_test_framework {
       _required_ver_ *= 1000;                                             \
     }                                                                     \
     int _actual_ver_ = GetGooglePlayServicesVersion();                    \
-    if (_actual_ver_ < _required_ver_) {                                  \
+    if (_actual_ver_ > 0 && _actual_ver_ < _required_ver_) {              \
       app_framework::LogInfo(                                             \
           "Skipping %s, as Google Play services %d is below required %d", \
           test_info_->name(), _actual_ver_, _required_ver_);              \
@@ -224,7 +225,7 @@ namespace firebase_test_framework {
     }                                                                     \
   }
 #else
-#define SKIP_TEST_ON_ANDROID_GOOGLE_PLAY_SERVICES_BELOW(x) ((void)0)
+#define SKIP_TEST_ON_ANDROID_IF_GOOGLE_PLAY_SERVICES_IS_OLDER_THAN(x) ((void)0)
 #endif  // defined(ANDROID)
 
 #if defined(STLPORT)
@@ -354,7 +355,8 @@ class FirebaseTest : public testing::Test {
   // on a real device (or on desktop).
   static bool IsRunningOnEmulator();
 
-  // Return Google Play services version on Android, 0 elsewhere.
+  // If on Android and Google Play services is available, returns the
+  // Google Play services version. Otherwise, returns 0.
   static int GetGooglePlayServicesVersion();
 
   // Returns true if the future completed as expected, fails the test and