File tree Expand file tree Collapse file tree 2 files changed +3
-21
lines changed
testing/test_framework/src
android/java/com/google/firebase/example Expand file tree Collapse file tree 2 files changed +3
-21
lines changed Original file line number Diff line number Diff line change 1616
1717import android .content .Context ;
1818import android .os .Build ;
19- import java .lang .Class ;
20- import java .lang .reflect .Method ;
19+ import com .google .android .gms .common .GoogleApiAvailability ;
2120
2221/**
2322 * A simple class with test helper methods.
@@ -32,22 +31,6 @@ public static boolean isRunningOnEmulator() {
3231 || Build .DEVICE .contains ("vbox86p" ) || Build .HARDWARE .contains ("vbox86" );
3332 }
3433 public static int getGooglePlayServicesVersion (Context context ) {
35- // Use reflection to invoke GoogleApiAvailability.getInstance().getApkVersion(context).
36- // This avoids needing Google Play services to be present (and returns 0 if it's not)..
37-
38- // GoogleApiAvailability
39- Class <?> googleApiAvailabilityClass = Class .forName ("com.google.android.gms.common.GoogleApiAvailability" );
40- if (googleApiAvailabilityClass == null ) {
41- return 0 ;
42- }
43- // .getInstance()
44- Method getInstanceMethod = googleApiAvailabilityClass .getDeclaredMethod ("getInstance" );
45- Object instance = getInstanceMethod .invoke (null );
46-
47- // .getApkVersion(context)
48- Method getApkVersionMethod = googleApiAvailabilityClass .getMethod ("getApkVersion" , new Class []{context .class });
49- Object apkVersionObject = getInstanceMethod .invoke (instance , context );
50-
51- int apkVersion = apkVersionObject .intValue ;
34+ return GoogleApiAvailability .getInstance ().getApkVersion (context );
5235 }
5336}
Original file line number Diff line number Diff line change @@ -354,8 +354,7 @@ class FirebaseTest : public testing::Test {
354354 // on a real device (or on desktop).
355355 static bool IsRunningOnEmulator ();
356356
357- // If on Android and Google Play services is available, returns the
358- // Google Play services version. Otherwise, returns 0.
357+ // Return Google Play services version on Android, 0 elsewhere.
359358 static int GetGooglePlayServicesVersion ();
360359
361360 // Returns true if the future completed as expected, fails the test and
You can’t perform that action at this time.
0 commit comments