Skip to content

fix: some validateAdminArgs unit tests wouldn't actually fail under incorrect behavior #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: some validateAdminArgs unit tests wouldn't actually fail under incorrect behavior #3009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b3037
fix validate unit tests
stephenarosaj Nov 7, 2025
3c37526
Merge branch 'master' into rosa/validate-tests
stephenarosaj Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 41 additions & 21 deletions test/unit/data-connect/validate-admin-args.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,25 +179,33 @@ describe('validateAdminArgs()', () => {
describe('and validateVars = true', () => {
describe('should succeed if vars WERE provided', () => {
it('and the first argument is a DataConnect instance', () => {
let dcInstance, inputVars, inputOpts;
expect(() => {
const { dc: dcInstance, vars: inputVars, options: inputOpts } = validateAdminArgs(
const parsedArgs = validateAdminArgs(
connectorConfig, providedDcInstance, variables, undefined, true, true
);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
}).to.not.throw(invalidVariablesError);
dcInstance = parsedArgs.dc;
inputVars = parsedArgs.vars;
inputOpts = parsedArgs.options;
}).to.not.throw(invalidVariablesError);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
});

it('and the first argument is variables instance', () => {
let dcInstance, inputVars, inputOpts;
expect(() => {
const { dc: dcInstance, vars: inputVars, options: inputOpts } = validateAdminArgs(
const parsedArgs = validateAdminArgs(
connectorConfig, variables, undefined, undefined, true, true
);
expect(dcInstance).to.deep.equal(stubDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
dcInstance = parsedArgs.dc;
inputVars = parsedArgs.vars;
inputOpts = parsedArgs.options;
}).to.not.throw(invalidVariablesError);
expect(dcInstance).to.deep.equal(stubDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
});
});

Expand All @@ -219,14 +227,18 @@ describe('validateAdminArgs()', () => {
describe('and validateVars = false', () => {
describe('should succeed if vars WERE provided', () => {
it('and the first argument is a DataConnect instance', () => {
let dcInstance, inputVars, inputOpts;
expect(() => {
const { dc: dcInstance, vars: inputVars, options: inputOpts } = validateAdminArgs(
const parsedArgs = validateAdminArgs(
connectorConfig, providedDcInstance, variables, undefined, true, false
);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.be.undefined;
expect(inputOpts).to.be.undefined;
dcInstance = parsedArgs.dc;
inputVars = parsedArgs.vars;
inputOpts = parsedArgs.options;
}).to.not.throw(invalidVariablesError);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
});

it('and the first argument is variables instance', () => {
Expand All @@ -245,25 +257,33 @@ describe('validateAdminArgs()', () => {

describe('should succeed if vars were NOT provided', () => {
it('and the first argument is a DataConnect instance', () => {
let dcInstance, inputVars, inputOpts;
expect(() => {
const { dc: dcInstance, vars: inputVars, options: inputOpts } = validateAdminArgs(
const parsedArgs = validateAdminArgs(
connectorConfig, providedDcInstance, undefined, undefined, true, false
);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.deep.equal(variables);
expect(inputOpts).to.be.undefined;
dcInstance = parsedArgs.dc;
inputVars = parsedArgs.vars;
inputOpts = parsedArgs.options;
}).to.not.throw(invalidVariablesError);
expect(dcInstance).to.deep.equal(providedDcInstance);
expect(inputVars).to.be.undefined;
expect(inputOpts).to.be.undefined;
});

it('and the first argument is undefined variables', () => {
let dcInstance, inputVars, inputOpts;
expect(() => {
const { dc: dcInstance, vars: inputVars, options: inputOpts } = validateAdminArgs(
const parsedArgs = validateAdminArgs(
connectorConfig, undefined, undefined, undefined, true, false
);
expect(dcInstance).to.deep.equal(stubDcInstance);
expect(inputVars).to.be.undefined;
expect(inputOpts).to.be.undefined;
dcInstance = parsedArgs.dc;
inputVars = parsedArgs.vars;
inputOpts = parsedArgs.options;
}).to.not.throw(invalidVariablesError);
expect(dcInstance).to.deep.equal(stubDcInstance);
expect(inputVars).to.be.undefined;
expect(inputOpts).to.be.undefined;
});
});
});
Expand Down