refactor: consolidate TS types #1275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…models.ts to ui/types.ts
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Replace generic data/setData with repo versions
…onsolidate-ts-types
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
- Coverage 83.36% 83.35% -0.01%
==========================================
Files 70 70
Lines 3005 3004 -1
Branches 499 499
==========================================
- Hits 2505 2504 -1
Misses 397 397
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andypols
approved these changes
Nov 8, 2025
Contributor
andypols
left a comment
andypols
left a comment
There was a problem hiding this comment.
LGTM 👍
Just a question out of curiosity — and no need to change anything in this PR — what’s the current thinking on when to append Data or FormData to type/interface names? I know the codebase has been a bit inconsistent, and it’s great that you’re tidying that up here. It’s just not entirely clear to me what the convention is.
Just wondering if Form (and maybe even Data) adds much in AttestationFormData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1193.
This PR aims to eliminate redundant types and move existing types into more semantically/logically relevant locations.
It also fixes up some generic variable names in the UI (
data/setData, etc.) to make the codebase easier to search/understand.