Skip to content

Fix: Fixed issue where process details weren't displayed when deleting folders with open files #17830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2025
+20 −1
Merged

Fix: Fixed issue where process details weren't displayed when deleting folders with open files #17830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1964a33
Fix: Fixed an issue where deleting a folder containing locked files s…
workbysaran Nov 7, 2025
5e6629f
Fix: Batch file lock checks in folder deletion
workbysaran Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,26 @@ public async Task<IStorageHistory> DeleteItemsAsync(IList<IStorageItemWithPath>
else if (deleteResult.Items.Any(x => CopyEngineResult.Convert(x.HResult) == FileSystemStatusCode.InUse))
{
var failedSources = deleteResult.Items.Where(x => CopyEngineResult.Convert(x.HResult) == FileSystemStatusCode.InUse);
var filePath = failedSources.Select(x => x.Source); // When deleting only source can be in use but shell returns COPYENGINE_E_SHARING_VIOLATION_DEST for folders

var filesToCheck = new List<string>();
foreach (var failedSource in failedSources)
{
if (Directory.Exists(failedSource.Source))
{
try
{
var files = Directory.EnumerateFiles(failedSource.Source, "*", SearchOption.AllDirectories);
filesToCheck.AddRange(files);
}
catch { }
}
else if (File.Exists(failedSource.Source))
{
filesToCheck.Add(failedSource.Source);
}
}

var filePath = filesToCheck.Any() ? filesToCheck : failedSources.Select(x => x.Source);
var lockingProcess = WhoIsLocking(filePath);

switch (await GetFileInUseDialog(filePath, lockingProcess))
Expand Down
Loading