Skip to content

Commit 2ae01a1

Browse files
committed
Hide pane when no terminals
1 parent d08a384 commit 2ae01a1

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/Files.App/Utils/Terminal/ConPTY/Terminal.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ private static SafeFileHandle GetConsoleScreenBuffer()
138138
{
139139
var file = CreateFile(
140140
"CONOUT$",
141-
(FILE_ACCESS_FLAGS)(Win32PInvoke.GENERIC_WRITE | Win32PInvoke.GENERIC_READ),
141+
Win32PInvoke.GENERIC_WRITE | Win32PInvoke.GENERIC_READ,
142142
FILE_SHARE_MODE.FILE_SHARE_WRITE,
143143
null,
144144
FILE_CREATION_DISPOSITION.OPEN_EXISTING,

src/Files.App/ViewModels/MainPageViewModel.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ public MainPageViewModel()
9292
NavigateToNumberedTabKeyboardAcceleratorCommand = new RelayCommand<KeyboardAcceleratorInvokedEventArgs>(ExecuteNavigateToNumberedTabKeyboardAcceleratorCommand);
9393
TerminalAddCommand = new RelayCommand<ShellProfile>((e) =>
9494
{
95+
if (Terminals.IsEmpty())
96+
IsTerminalViewOpen = true;
9597
Terminals.Add(new TerminalView(e ?? TerminalSelectedProfile)
9698
{
9799
Tag = $"Terminal {Terminals.Count}"
@@ -124,6 +126,8 @@ public MainPageViewModel()
124126
(terminal as IDisposable)?.Dispose();
125127
Terminals.Remove(terminal);
126128
SelectedTerminal = int.Min(SelectedTerminal, Terminals.Count - 1);
129+
if (Terminals.IsEmpty())
130+
IsTerminalViewOpen = false;
127131
OnPropertyChanged(nameof(ActiveTerminal));
128132
OnPropertyChanged(nameof(TerminalNames));
129133
});
@@ -169,11 +173,6 @@ private void MainPageViewModel_PropertyChanged(object? sender, PropertyChangedEv
169173
SetTerminalFolder = null;
170174
}
171175
}
172-
else if (e.PropertyName == nameof(SelectedTerminal))
173-
{
174-
if (Terminals.IsEmpty())
175-
IsTerminalViewOpen = false;
176-
}
177176
}
178177

179178
private void GeneralSettingsService_PropertyChanged(object? sender, PropertyChangedEventArgs e)

0 commit comments

Comments
 (0)