Merge branch 'main' of https://github.com/files-community/Files into terminal

Author: gave92

.github/PULL_REQUEST_TEMPLATE.md

@@ -7,20 +7,13 @@ I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
 -->
 
 **Resolved / Related Issues**
-- [ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
-   Closes #issue...
 
-**Validation**
-How did you test these changes?
-- [ ] Did you build the app and test your changes?
-- [ ] Did you check for accessibility? You can use Accessibility Insights for this.
-- [ ] Did you remove any strings from the en-us resource file?
-   - [ ] Did you search the solution to see if the string is still being used? 
-- [ ] Did you implement any design changes to an existing feature?
-   - [ ] Was this change approved?
-- [ ] Are there any other steps that were used to validate these changes?
-   1. Open app ...
-   2. Click settings button ...
+To prevent extra work, all changes to the Files codebase must link to an approved issue marked as `Ready to build`. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.
+- Closes #
 
-**Screenshots (optional)**
-Add screenshots here.
+**Steps used to test these changes**
+
+Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
+
+1. Opened Files ...
+2. ...

crowdin.yml

@@ -1,20 +1,5 @@
 commit_message: 'fix: new translations in %original_file_name% (%original_file_name%) from Crowdin'
-append_commit_message: false
+append_commit_message: 
 files:
   - source: /src/Files.App/Strings/en-US/*.resw
     translation: /src/Files.App/Strings/%locale%/%original_file_name%
-    languages_mapping:
-      locale:
-        af: af
-        ar: ar
-        bg: bg
-        ca: ca
-        da: da
-        el: el
-        ka: ka
-        no: nb-NO
-        zh-CN: zh-Hans
-        zh-TW: zh-Hant
-        vi: vi
-        ta: ta
-        lt-LT: lt

src/Files.App (Package)/Files.Package.wapproj

@@ -14,7 +14,7 @@
     <DisableXbfLineInfo>False</DisableXbfLineInfo>
     <GenerateTestArtifacts>True</GenerateTestArtifacts>
     <AppxBundleAutoResourcePackageQualifiers>Scale|DXFeatureLevel</AppxBundleAutoResourcePackageQualifiers>
-    <AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;da-DK;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hu-HU;id-ID;it-IT;ja-JP;ka;ko-KR;lt;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
+    <AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hr-HR;hu-HU;id-ID;it-IT;ja-JP;ka;km-KH;ko-KR;ku-Arab;lt-LT;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sq-AL;sr-Cyrl;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
     <UapAppxPackageBuildMode>StoreUpload</UapAppxPackageBuildMode>
     <HoursBetweenUpdateChecks>255</HoursBetweenUpdateChecks>
     <EntryPointProjectUniqueName>..\Files.App\Files.App.csproj</EntryPointProjectUniqueName>
@@ -107,7 +107,7 @@
     </ProjectReference>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240404000" IncludeAssets="build" />
+    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240428000" IncludeAssets="build" />
     <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" IncludeAssets="build" />
   </ItemGroup>
   <Import Project="$(WapProjPath)\Microsoft.DesktopBridge.targets" />

src/Files.App (Package)/Package.appxmanifest

@@ -16,7 +16,7 @@
     <Identity
         Name="FilesDev"
         Publisher="CN=Files"
-        Version="3.3.6.0" />
+        Version="3.4.0.0" />
 
     <Properties>
         <DisplayName>Files - Dev</DisplayName>
@@ -37,7 +37,6 @@
         <Resource Language="ca" />
         <Resource Language="cs-CZ" />
         <Resource Language="da" />
-        <Resource Language="da-DK" />
         <Resource Language="de-DE" />
         <Resource Language="el" />
         <Resource Language="en-GB" />
@@ -55,8 +54,10 @@
         <Resource Language="it-IT" />
         <Resource Language="ja-JP" />
         <Resource Language="ka" />
+        <Resource Language="km-KH" />
         <Resource Language="ko-KR" />
-        <Resource Language="lt" />
+        <Resource Language="ku-Arab" />
+        <Resource Language="lt-LT" />
         <Resource Language="lv-LV" />
         <Resource Language="nb-NO" />
         <Resource Language="nl-NL" />
@@ -66,7 +67,9 @@
         <Resource Language="pt-PT" />
         <Resource Language="ro-RO" />
         <Resource Language="ru-RU" />
-        <Resource Language="sk-SK" />             
+        <Resource Language="sk-SK" />
+        <Resource Language="sq-AL" />
+        <Resource Language="sr-Cyrl" />
         <Resource Language="sv-SE" />
         <Resource Language="ta" />
         <Resource Language="th-TH" />

src/Files.App.Server/AppInstanceMonitor.cs

@@ -1,13 +1,15 @@
 // Copyright (c) 2024 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
+using System.Collections.Concurrent;
 using System.Diagnostics;
 
 namespace Files.App.Server;
 
 public sealed class AppInstanceMonitor
 {
 	private static int processCount = 0;
+	internal static ConcurrentDictionary<int, ConcurrentBag<IDisposable>> AppInstanceResources = new();
 
 	public static void StartMonitor(int processId)
 	{
@@ -19,10 +21,18 @@ public static void StartMonitor(int processId)
 
 	private static void Process_Exited(object? sender, EventArgs e)
 	{
-		if (sender is Process process)
+		if (sender is Process { Id: var processId } process)
 		{
 			process.Dispose();
 
+			if (AppInstanceResources.TryRemove(processId, out var instances))
+			{
+				foreach (var instance in instances)
+				{
+					instance.Dispose();
+				}
+			}
+
 			if (Interlocked.Decrement(ref processCount) == 0)
 			{
 				Program.ExitSignalEvent.Set();

src/Files.App.Server/Database/FileTagsDatabase.cs

@@ -6,6 +6,7 @@
 using LiteDB;
 using Microsoft.Win32;
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.WindowsRuntime;
 using System.Text;
 using Windows.ApplicationModel;
@@ -17,13 +18,16 @@
 
 namespace Files.App.Server.Database
 {
-	public sealed class FileTagsDatabase
+	public sealed class FileTagsDatabase : IDisposable
 	{
 		private readonly static string FileTagsKey = @$"Software\Files Community\{Package.Current.Id.FullName}\v1\FileTags";
 
 		private readonly static string FileTagsDbPath = Path.Combine(ApplicationData.Current.LocalFolder.Path, "filetags.db");
 		private const string FileTagsCollectionName = "taggedfiles";
 
+		private readonly GCHandle _handle;
+		private bool _disposed = false;
+
 		static FileTagsDatabase()
 		{
 			if (File.Exists(FileTagsDbPath))
@@ -44,6 +48,25 @@ static FileTagsDatabase()
 			}
 		}
 
+		public FileTagsDatabase()
+		{
+			throw new NotSupportedException($"Instantiating {nameof(FileTagsDatabase)} by non-parameterized constructor is not supported.");
+		}
+
+		public FileTagsDatabase(int processId)
+		{
+			_handle = GCHandle.Alloc(this, GCHandleType.Pinned);
+
+			if (AppInstanceMonitor.AppInstanceResources.TryGetValue(processId, out var instances))
+			{
+				instances.Add(this);
+			}
+			else
+			{
+				AppInstanceMonitor.AppInstanceResources[processId] = [this];
+			}
+		}
+
 		private static void UpdateDb(LiteDatabase database)
 		{
 			if (database.UserVersion == 0)
@@ -279,5 +302,14 @@ private void IterateKeys(List<TaggedFile> list, string path, int depth)
 				IterateKeys(list, CombineKeys(path, subKey), depth + 1);
 			}
 		}
+
+		public void Dispose()
+		{
+			if (!_disposed)
+			{
+				_disposed = true;
+				_handle.Free();
+			}
+		}
 	}
 }

src/Files.App.Server/Database/LayoutPreferencesDatabase.cs

@@ -5,6 +5,7 @@
 using LiteDB;
 using Microsoft.Win32;
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using Windows.ApplicationModel;
 using Windows.Storage;
 using static Files.App.Server.Data.LayoutPreferencesRegistry;
@@ -13,13 +14,16 @@
 
 namespace Files.App.Server.Database
 {
-	public sealed class LayoutPreferencesDatabase
+	public sealed class LayoutPreferencesDatabase : IDisposable
 	{
 		private readonly static string LayoutSettingsKey = @$"Software\Files Community\{Package.Current.Id.FullName}\v1\LayoutPreferences";
 
 		private readonly static string LayoutSettingsDbPath = Path.Combine(ApplicationData.Current.LocalFolder.Path, "user_settings.db");
 		private const string LayoutSettingsCollectionName = "layoutprefs";
 
+		private readonly GCHandle _handle;
+		private bool _disposed = false;
+
 		static LayoutPreferencesDatabase()
 		{
 			if (File.Exists(LayoutSettingsDbPath))
@@ -37,6 +41,25 @@ static LayoutPreferencesDatabase()
 			}
 		}
 
+		public LayoutPreferencesDatabase()
+		{
+			throw new NotSupportedException($"Instantiating {nameof(LayoutPreferencesDatabase)} by non-parameterized constructor is not supported.");
+		}
+
+		public LayoutPreferencesDatabase(int processId)
+		{
+			_handle = GCHandle.Alloc(this, GCHandleType.Pinned);
+
+			if (AppInstanceMonitor.AppInstanceResources.TryGetValue(processId, out var instances))
+			{
+				instances.Add(this);
+			}
+			else
+			{
+				AppInstanceMonitor.AppInstanceResources[processId] = [this];
+			}
+		}
+
 		public LayoutPreferencesItem? GetPreferences(string filePath, ulong? frn)
 		{
 			return FindPreferences(filePath, frn)?.LayoutPreferencesManager;
@@ -197,5 +220,14 @@ private void IterateKeys(List<LayoutPreferences> list, string path, int depth)
 
 			return null;
 		}
+
+		public void Dispose()
+		{
+			if (!_disposed)
+			{
+				_disposed = true;
+				_handle.Free();
+			}
+		}
 	}
 }

src/Files.App.Server/Files.App.Server.csproj

@@ -4,7 +4,7 @@
         <OutputType>WinExe</OutputType>
         <DefaultLanguage>en-US</DefaultLanguage>
         <AppxBundleAutoResourcePackageQualifiers>Scale|DXFeatureLevel</AppxBundleAutoResourcePackageQualifiers>
-        <AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;da-DK;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hu-HU;id-ID;it-IT;ja-JP;ka;ko-KR;lt;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
+        <AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hr-HR;hu-HU;id-ID;it-IT;ja-JP;ka;km-KH;ko-KR;ku-Arab;lt-LT;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sq-AL;sr-Cyrl;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
         <TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
         <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
         <ImplicitUsings>enable</ImplicitUsings>

src/Files.App/Actions/Content/Archives/Compress/BaseCompressArchiveAction.cs

@@ -23,7 +23,7 @@ public BaseCompressArchiveAction()
 			context.PropertyChanged += Context_PropertyChanged;
 		}
 
-		public abstract Task ExecuteAsync();
+		public abstract Task ExecuteAsync(object? parameter = null);
 
 		private bool IsContextPageTypeAdaptedToCommand()
 		{

src/Files.App/Actions/Content/Archives/Compress/CompressIntoArchiveAction.cs

@@ -19,7 +19,7 @@ public CompressIntoArchiveAction()
 		{
 		}
 
-		public override async Task ExecuteAsync()
+		public override async Task ExecuteAsync(object? parameter = null)
 		{
 			if (context.ShellPage is null)
 				return;