Skip to content

Handle non-lowercase repository names #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
febus982 merged 3 commits into from
Mar 7, 2025
Merged

Handle non-lowercase repository names #272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e9bad7
Handle non-lowercase repository names
febus982 Mar 6, 2025
914513a
Comment out branch tags
febus982 Mar 7, 2025
89044ce
Remove PR test code changes
febus982 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/ci-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,12 @@ jobs:
# Transform os/arch to os-arch for suffix target
- name: Set ENV variables
run: |
echo "IMAGE_NAME=${GITHUB_REPOSITORY#$GITHUB_REPOSITORY_OWNER/}" >> $GITHUB_ENV
image_name=${GITHUB_REPOSITORY#$GITHUB_REPOSITORY_OWNER/}
echo "IMAGE_NAME=$image_name" >> $GITHUB_ENV
platform=${{ matrix.arch.platform }}
echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
image_without_tag=${{ env.REGISTRY }}/${{ env.REGISTRY_PATH }}/$image_name-${{ matrix.docker_target }}
echo "FULL_IMAGE_WITHOUT_TAG=$(echo $image_without_tag | tr '[A-Z]' '[a-z]')" >> $GITHUB_ENV

- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -168,7 +171,7 @@ jobs:
target: ${{ matrix.docker_target }}
platforms: ${{ matrix.arch.platform }}
outputs: type=image,push-by-digest=true,name-canonical=true,push=true
tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_PATH }}/${{ env.IMAGE_NAME }}-${{ matrix.docker_target }}
tags: ${{ env.FULL_IMAGE_WITHOUT_TAG }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=registry,ref=${{ steps.meta-cache.outputs.tags }}
cache-to: type=registry,ref=${{ steps.meta-cache.outputs.tags }},mode=max
Expand Down Expand Up @@ -211,7 +214,10 @@ jobs:
# Set IMAGE_NAME so we can push to <owner>/<repo>/<image>
- name: Set ENV variables
run: |
echo "IMAGE_NAME=${GITHUB_REPOSITORY#$GITHUB_REPOSITORY_OWNER/}" >> $GITHUB_ENV
image_name=${GITHUB_REPOSITORY#$GITHUB_REPOSITORY_OWNER/}
echo "IMAGE_NAME=$image_name" >> $GITHUB_ENV
image_without_tag=${{ env.REGISTRY }}/${{ env.REGISTRY_PATH }}/$image_name-${{ matrix.docker_target }}
echo "FULL_IMAGE_WITHOUT_TAG=$(echo $image_without_tag | tr '[A-Z]' '[a-z]')" >> $GITHUB_ENV

- name: Download digests
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -257,11 +263,11 @@ jobs:
working-directory: ${{ runner.temp }}/digests/${{ matrix.docker_target }}
run: |
docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
$(printf '${{ env.REGISTRY }}/${{ env.REGISTRY_PATH }}/${{ env.IMAGE_NAME }}-${{ matrix.docker_target }}@sha256:%s ' *)
$(printf '${{ env.FULL_IMAGE_WITHOUT_TAG }}@sha256:%s ' *)

- name: Inspect image
run: |
docker buildx imagetools inspect ${{ env.REGISTRY }}/${{ env.REGISTRY_PATH }}/${{ env.IMAGE_NAME }}-${{ matrix.docker_target }}:${{ steps.meta.outputs.version }}
docker buildx imagetools inspect ${{ env.FULL_IMAGE_WITHOUT_TAG }}:${{ steps.meta.outputs.version }}

#TODO: Implement signature using generated key: https://docs.sigstore.dev/signing/quickstart/#signing-with-a-generated-key

Expand Down