Dual boot 7.0 and 7.1 #103
Conversation
|
I added a bug report in the skunk repo, it's failing because the skunk score improved #104 (not really an improvement for any particular file, but we have more files now so the average improved) |
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@arielj I see that the new framework defaults are commented. Shouldn't we try with new framework defaults to see if everything works as expected?
Please let me know
We could, it's not something required though (it could be done after the upgrade in another PR, the Rails docs recommend doing that over time and multiple deployments https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#configure-framework-defaults). So it's not needed, but I can try that (we have to consider that there are some changes there that require extra changes, like changing the encryption key requires adding a cookie rotator that has to be removed in the future https://github.com/fastruby/skunk.fyi/pull/103/files#diff-eea1c50635a8c62e2b5a61e4e6526c06b9a172c2c7eb6e071dc4b42722b8d5f6R19-R26 ) I do think skunk.fyi is so simple that it's probably safe to just change the maybe we need another PR/story to upgrade the defaults gradually? |
|
@arielj Would you kindly solve merge conflicts so that we can proceed to Rails 7? cc @etagwerker |
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@arielj This looks good but I'm getting an error when doing QA with Rails 7.1
Here is the error:
Started POST "/reports" for ::1 at 2025-11-13 15:54:50 -0500
ActiveRecord::SchemaMigration Load (0.5ms) SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
Processing by ReportsController#create as */*
Parameters: {"{\"entries\":"=>{"{\"file\":\"lib/skunk/commands/status_sharer.rb\",\"skunk_score\":140.36,\"churn_times_cost\":18.19,\"churn\":7,\"cost\":2.6,\"coverage\":46.81},{\"file\":\"lib/skunk/generators/html_report.rb\",\"skunk_score\":90.2,\"churn_times_cost\":0.9,\"churn\":1,\"cost\":0.9,\"coverage\":0.0},{\"file\":\"lib/skunk/generators/html/overview.rb\",\"skunk_score\":70.4,\"churn_times_cost\":1.41,\"churn\":2,\"cost\":0.7,\"coverage\":0.0},{\"file\":\"lib/skunk/generators/html/file_data.rb\",\"skunk_score\":47.32,\"churn_times_cost\":0.47,\"churn\":1,\"cost\":0.47,\"coverage\":0.0},{\"file\":\"lib/skunk/config.rb\",\"skunk_score\":13.37,\"churn_times_cost\":1.34,\"churn\":1,\"cost\":1.34,\"coverage\":90.24},{\"file\":\"lib/skunk/cli/application.rb\",\"skunk_score\":7.06,\"churn_times_cost\":21.19,\"churn\":18,\"cost\":1.18,\"coverage\":94.12},{\"file\":\"lib/skunk/commands/status_reporter.rb\",\"skunk_score\":5.94,\"churn_times_cost\":41.55,\"churn\":21,\"cost\":1.98,\"coverage\":97.3},{\"file\":\"lib/skunk/rubycritic/analysed_modules_collection.rb\",\"skunk_score\":2.41,\"churn_times_cost\":12.03,\"churn\":5,\"cost\":2.41,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/compare.rb\",\"skunk_score\":2.01,\"churn_times_cost\":2.01,\"churn\":1,\"cost\":2.01,\"coverage\":100.0},{\"file\":\"lib/skunk/rubycritic/analysed_module.rb\",\"skunk_score\":1.39,\"churn_times_cost\":16.64,\"churn\":12,\"cost\":1.39,\"coverage\":100.0},{\"file\":\"lib/skunk/cli/options/argv.rb\",\"skunk_score\":0.82,\"churn_times_cost\":8.16,\"churn\":10,\"cost\":0.82,\"coverage\":100.0},{\"file\":\"lib/skunk/cli/options.rb\",\"skunk_score\":0.68,\"churn_times_cost\":4.76,\"churn\":7,\"cost\":0.68,\"coverage\":100.0},{\"file\":\"lib/skunk/generators/html/path_truncator.rb\",\"skunk_score\":0.66,\"churn_times_cost\":0.66,\"churn\":1,\"cost\":0.66,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/compare_score.rb\",\"skunk_score\":0.63,\"churn_times_cost\":0.63,\"churn\":1,\"cost\":0.63,\"coverage\":100.0},{\"file\":\"lib/skunk/reporter.rb\",\"skunk_score\":0.52,\"churn_times_cost\":1.03,\"churn\":2,\"cost\":0.52,\"coverage\":100.0},{\"file\":\"lib/skunk/command_factory.rb\",\"skunk_score\":0.49,\"churn_times_cost\":0.49,\"churn\":1,\"cost\":0.49,\"coverage\":100.0},{\"file\":\"lib/skunk/generators/json/simple.rb\",\"skunk_score\":0.45,\"churn_times_cost\":1.34,\"churn\":3,\"cost\":0.45,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/default.rb\",\"skunk_score\":0.44,\"churn_times_cost\":1.31,\"churn\":3,\"cost\":0.44,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/shareable.rb\",\"skunk_score\":0.24,\"churn_times_cost\":0.48,\"churn\":2,\"cost\":0.24,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/help.rb\",\"skunk_score\":0.2,\"churn_times_cost\":0.2,\"churn\":1,\"cost\":0.2,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/base.rb\",\"skunk_score\":0.1,\"churn_times_cost\":0.2,\"churn\":2,\"cost\":0.1,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/output.rb\",\"skunk_score\":0.09,\"churn_times_cost\":0.19,\"churn\":2,\"cost\":0.09,\"coverage\":100.0},{\"file\":\"lib/skunk/commands/version.rb\",\"skunk_score\":0.09,\"churn_times_cost\":0.09,\"churn\":1,\"cost\":0.09,\"coverage\":100.0},{\"file\":\"lib/skunk/generators/json_report.rb\",\"skunk_score\":0.09,\"churn_times_cost\":0.09,\"churn\":1,\"cost\":0.09,\"coverage\":100.0},{\"file\":\"lib/skunk/version.rb\",\"skunk_score\":0.0,\"churn_times_cost\":0.0,\"churn\":14,\"cost\":0.0,\"coverage\":0.0},{\"file\":\"lib/skunk.rb\",\"skunk_score\":0.0,\"churn_times_cost\":0.0,\"churn\":5,\"cost\":0.0,\"coverage\":100.0}"=>{",\"summary\":{\"total_skunk_score\":385.96000000000004,\"analysed_modules_count\":26,\"skunk_score_average\":14.84,\"skunk_version\":\"0.5.4\",\"worst_skunk_score\":{\"file\":\"lib/skunk/c
Had to update Puma to v6 to support Rack 3
ommands/status_sharer.rb\",\"skunk_score\":140.36}},\"options\":{\"compare\":\"false\"}}"=>nil}}}
Error: unexpected end of input at line 1 column 1 ||
Completed 400 Bad Request in 0ms (ActiveRecord: 0.0ms | Allocations: 636)
Description:
This PR updates the app to use 7.0 and dual boot with 7.1.
I also updated some config files based on changes from running
rails app:updateI will abide by the code of conduct.