Pass an already imported module in helper #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when running in environment that transpile on the fly, such as Jest/Vitest and so on, which don't handle the dynamic import all that well.
segevfiner
force-pushed
the
already-imported-module-in-helper
branch
from
55ccbc2 to
b9e686c
Compare
ilteoood
reviewed
Oct 6, 2025
ilteoood
reviewed
Nov 6, 2025
Co-authored-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com> Signed-off-by: Segev Finer <segev208@gmail.com>
Co-authored-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com> Signed-off-by: Segev Finer <segev208@gmail.com>
Eomm
reviewed
Nov 8, 2025
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Segev Finer <segev208@gmail.com>
Eomm
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when running in environment that
transpile on the fly, such as Jest/Vitest and so
on, which don't handle the dynamic import all that
well.
Checklist
npm run testandnpm run benchmarkand the Code of conduct