Skip to content

Conversation

@fairdataihub-bot
Copy link
Member

Automated changes by create-pull-request GitHub action

@fairdataihub-bot fairdataihub-bot force-pushed the create-pull-request/patch branch 3 times, most recently from db4df02 to bfb34b3 Compare April 29, 2022 07:03
@fairdataihub-bot fairdataihub-bot force-pushed the create-pull-request/patch branch from bfb34b3 to 6333dbf Compare May 27, 2022 17:54
@sourcery-ai
Copy link

sourcery-ai bot commented May 27, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 4.32 ⭐ 4.32 ⭐ 0.00
Method Length 94.90 🙂 94.90 🙂 0.00
Working memory 8.10 🙂 8.10 🙂 0.00
Quality 65.35% 🙂 65.35% 🙂 0.00%
Other metrics Before After Change
Lines 411 411 0
Changed files Quality Before Quality After Quality Change
app/osparc/job_api.py 65.35% 🙂 65.35% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
app/osparc/job_api.py check_job_status 10 🙂 292 ⛔ 10 😞 43.77% 😞 Try splitting into smaller methods. Extract out complex expressions
app/osparc/job_api.py check_python_job_status 5 ⭐ 138 😞 9 🙂 61.33% 🙂 Try splitting into smaller methods
app/osparc/job_api.py start_osparc_job 3 ⭐ 135 😞 9 🙂 63.65% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants