Skip to content

m_auto_incr_map: reduce a redundant search operation #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: fb-mysql-8.0.28
Choose a base branch
from
Open

m_auto_incr_map: reduce a redundant search operation #1259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions storage/rocksdb/ha_rocksdb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4200,14 +4200,15 @@ class Rdb_transaction {
}

void set_auto_incr(const GL_INDEX_ID &gl_index_id, ulonglong curr_id) {
m_auto_incr_map[gl_index_id] =
std::max(m_auto_incr_map[gl_index_id], curr_id);
auto& existing = m_auto_incr_map[gl_index_id];
existing = std::max(existing, curr_id);
}

#ifndef NDEBUG
ulonglong get_auto_incr(const GL_INDEX_ID &gl_index_id) {
if (m_auto_incr_map.count(gl_index_id) > 0) {
return m_auto_incr_map[gl_index_id];
auto iter = m_auto_incr_map.find(gl_index_id);
if (m_auto_incr_map.end() != iter) {
return iter->second;
}
return 0;
}
Expand Down